Re: [gem5-dev] Review Request 3757: arch: added generic vector register

2017-01-26 Thread Rekai Gonzalez Alberquilla
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3757/ --- (Updated Jan. 26, 2017, 11:20 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3757: arch: added generic vector register

2017-01-24 Thread Rekai Gonzalez Alberquilla
> On Jan. 20, 2017, 5:11 p.m., Tony Gutierrez wrote: > > LGTM, nice implementation. I just have an ask for a few more comments. > > > > 1) A high-level description of the API, and some direction on usage for > > this library would be useful as a top-level comment in the file. > > 2) LaneData

Re: [gem5-dev] Review Request 3757: arch: added generic vector register

2017-01-24 Thread Rekai Gonzalez Alberquilla
> On Jan. 19, 2017, 10:28 p.m., Jason Lowe-Power wrote: > > Seems OK to me. Don't let anyone ever tell you that C++ makes reading code > > easy... I appreciate all of the compile-time tricks going on here, but it > > is incredibly difficult to read. > > > > Maybe some more comments for each

Re: [gem5-dev] Review Request 3757: arch: added generic vector register

2017-01-20 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3757/#review9292 --- Ship it! LGTM, nice implementation. I just have an ask for a few more

Re: [gem5-dev] Review Request 3757: arch: added generic vector register

2017-01-19 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3757/#review9286 --- Ship it! Seems OK to me. Don't let anyone ever tell you that C++ makes

Re: [gem5-dev] Review Request 3757: arch: added generic vector register

2017-01-16 Thread Rekai Gonzalez Alberquilla
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3757/ --- (Updated Jan. 16, 2017, 11:54 a.m.) Review request for Default. Repository: gem5

[gem5-dev] Review Request 3757: arch: added generic vector register

2016-12-10 Thread Rekai Gonzalez Alberquilla
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3757/ --- Review request for Default. Repository: gem5 Description --- Changeset