Re: [gem5-dev] Review Request 3785: sim, kvm: make KvmVM a System parameter

2017-01-30 Thread Alexandru Dutu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3785/#review9349 --- Ship it! Ship It! - Alexandru Dutu On Jan. 17, 2017, 10:04 p.m., Curt

Re: [gem5-dev] Review Request 3785: sim, kvm: make KvmVM a System parameter

2017-01-30 Thread Curtis Dunham
> On Jan. 26, 2017, 10:14 p.m., Alexandru Dutu wrote: > > src/sim/system.cc, line 98 > > > > > > Sorry, I should have been more specific. I meant by not conditioning > > System.kvm_vm by USE_KVM in System.py and have it be n

Re: [gem5-dev] Review Request 3785: sim, kvm: make KvmVM a System parameter

2017-01-26 Thread Alexandru Dutu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3785/#review9330 --- src/sim/system.cc (line 98)

Re: [gem5-dev] Review Request 3785: sim, kvm: make KvmVM a System parameter

2017-01-26 Thread Curtis Dunham
> On Jan. 26, 2017, 5:21 p.m., Alexandru Dutu wrote: > > src/sim/system.cc, line 98 > > > > > > It seems we don't need #if here, p->kvm_vm will be nullptr in case > > there is no initialization from python. Right? System.py

Re: [gem5-dev] Review Request 3785: sim, kvm: make KvmVM a System parameter

2017-01-26 Thread Alexandru Dutu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3785/#review9323 --- src/sim/system.cc (line 98)

Re: [gem5-dev] Review Request 3785: sim, kvm: make KvmVM a System parameter

2017-01-24 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3785/#review9307 --- Ship it! Ship It! - Jason Lowe-Power On Jan. 17, 2017, 10:04 p.m., Cu

Re: [gem5-dev] Review Request 3785: sim, kvm: make KvmVM a System parameter

2017-01-24 Thread Jason Lowe-Power
> On Jan. 18, 2017, 4:02 p.m., Jason Lowe-Power wrote: > > Is there any way you can remove the #if USE_KVM from the system.cc file? I > > don't have any suggestions off the top of my head, though. > > Curtis Dunham wrote: > We agree that it's not the best, but we didn't see a better solutio

Re: [gem5-dev] Review Request 3785: sim, kvm: make KvmVM a System parameter

2017-01-24 Thread Curtis Dunham
> On Jan. 18, 2017, 4:02 p.m., Jason Lowe-Power wrote: > > Is there any way you can remove the #if USE_KVM from the system.cc file? I > > don't have any suggestions off the top of my head, though. We agree that it's not the best, but we didn't see a better solution to this problem. We are wil

Re: [gem5-dev] Review Request 3785: sim, kvm: make KvmVM a System parameter

2017-01-18 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3785/#review9259 --- Is there any way you can remove the #if USE_KVM from the system.cc file?

[gem5-dev] Review Request 3785: sim, kvm: make KvmVM a System parameter

2017-01-17 Thread Curtis Dunham
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3785/ --- Review request for Default. Repository: gem5 Description --- sim, kvm: make