Re: [gem5-dev] Review Request 3789: syscall_emul: #ifdef new system calls to allow builds on OSX and BSD

2017-01-20 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3789/#review9290 --- Ship it! Ship It! - Jason Lowe-Power On Jan. 19, 2017, 6:28 p.m.,

Re: [gem5-dev] Review Request 3789: syscall_emul: #ifdef new system calls to allow builds on OSX and BSD

2017-01-20 Thread Pierre-Yves Péneau
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3789/#review9289 --- Ship it! Ship It! - Pierre-Yves Péneau On Jan. 19, 2017, 7:28 p.m.,

Re: [gem5-dev] Review Request 3789: syscall_emul: #ifdef new system calls to allow builds on OSX and BSD

2017-01-19 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3789/#review9279 --- Ship it! Ship It! - Tony Gutierrez On Jan. 19, 2017, 10:28 a.m.,

Re: [gem5-dev] Review Request 3789: syscall_emul: #ifdef new system calls to allow builds on OSX and BSD

2017-01-19 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3789/ --- (Updated Jan. 19, 2017, 6:28 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3789: syscall_emul: #ifdef new system calls to allow builds on OSX and BSD

2017-01-19 Thread Brandon Potter
> On Jan. 19, 2017, 5:33 p.m., Tony Gutierrez wrote: > > LGTM, but just to clarify, you don't need to guard the inclusion of any > > system headers? There's a preexisting macro in that file for stat64 which uses the same exclusion method. It's verbatim what I copied except that I don't check

Re: [gem5-dev] Review Request 3789: syscall_emul: #ifdef new system calls to allow builds on OSX and BSD

2017-01-19 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3789/#review9274 --- Ship it! LGTM, but just to clarify, you don't need to guard the