Re: [gem5-dev] Review Request 3819: python: Add a generalized mechanism to configure stats

2017-02-23 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3819/#review9459 --- Ship it! Ship It! - Tony Gutierrez On Feb. 22, 2017, 2:02 a.m.,

Re: [gem5-dev] Review Request 3819: python: Add a generalized mechanism to configure stats

2017-02-22 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3819/#review9454 --- Ship it! Ship It! - Jason Lowe-Power On Feb. 22, 2017, 10:02 a.m.,

Re: [gem5-dev] Review Request 3819: python: Add a generalized mechanism to configure stats

2017-02-22 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3819/ --- (Updated Feb. 22, 2017, 10:02 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3819: python: Add a generalized mechanism to configure stats

2017-02-22 Thread Andreas Sandberg
> On Feb. 21, 2017, 7:14 p.m., Jason Lowe-Power wrote: > > src/python/m5/stats/__init__.py, line 105 > > > > > > Can we make this a little more explicit? I think using decorators is a > > little clearer. Like: > > > >

Re: [gem5-dev] Review Request 3819: python: Add a generalized mechanism to configure stats

2017-02-21 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3819/#review9443 --- I really like this interface! Cool idea. Just some comments on the

[gem5-dev] Review Request 3819: python: Add a generalized mechanism to configure stats

2017-02-21 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3819/ --- Review request for Default. Repository: gem5 Description --- Changeset