Re: [m5-dev] Review Request: ARM: Add I/O devices for booting linux

> On 2010-08-17 14:56:45, Ali Saidi wrote: > > src/base/intmath.hh, line 84 > > > > > > How about a warning if it's called with an exponent > 20? > > > > Steve Reinhardt wrote: > I'd prefer something a little more robust.

Re: [m5-dev] Review Request: ARM: Add I/O devices for booting linux

--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/164/#review228 --- src/base/intmath.hh The

Re: [m5-dev] Review Request: ARM: Add I/O devices for booting linux

> On 2010-08-17 14:56:45, Ali Saidi wrote: > > src/base/intmath.hh, line 84 > > > > > > How about a warning if it's called with an exponent > 20? > > > > Steve Reinhardt wrote: > I'd prefer something a little more robust.

Re: [m5-dev] Review Request: ARM: Add I/O devices for booting linux

> On 2010-08-17 14:56:45, Ali Saidi wrote: > > src/base/intmath.hh, line 84 > > > > > > How about a warning if it's called with an exponent > 20? > > > > Steve Reinhardt wrote: > I'd prefer something a little more robust.

Re: [m5-dev] Review Request: ARM: Add I/O devices for booting linux

> On 2010-08-17 14:56:45, Ali Saidi wrote: > > src/base/intmath.hh, line 84 > > > > > > How about a warning if it's called with an exponent > 20? > > > > Steve Reinhardt wrote: > I'd prefer something a little more robust.

Re: [m5-dev] Review Request: ARM: Add I/O devices for booting linux

> On 2010-08-17 14:56:45, Ali Saidi wrote: > > src/base/intmath.hh, line 84 > > > > > > How about a warning if it's called with an exponent > 20? > > I'd prefer something a little more robust. One option is to track old and n

Re: [m5-dev] Review Request: ARM: Add I/O devices for booting linux

--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/164/#review210 --- src/base/intmath.hh How

Re: [m5-dev] Review Request: ARM: Add I/O devices for booting linux

> On 2010-08-13 23:21:30, Gabe Black wrote: > > src/base/intmath.hh, line 84 > > > > > > This isn't particularly efficient. A better algorithm would be to > > square n over and over and multiply it in if the appropriate bit in

Re: [m5-dev] Review Request: ARM: Add I/O devices for booting linux

--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/164/#review194 --- src/dev/arm/timer_sp804.cc

Re: [m5-dev] Review Request: ARM: Add I/O devices for booting linux

--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/164/#review176 --- src/base/intmath.hh Thi

[m5-dev] Review Request: ARM: Add I/O devices for booting linux

--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/164/ --- Review request for Default. Summary --- ARM: Add I/O devices for booting linux