Re: [m5-dev] Review Request: ARM: Fix checkpoint restoration into O3 CPU and the way O3 switchCpu works.

2011-03-31 Thread Ali Saidi
Everyone, this change alters the way that the O3 cpu switches registers from the atomic cpu. If you use checkpoint/switchover and m5 please test this (specifically the change to src/cpu/o3/thread_context_impl.hh) Thanks, Ali On Mar 30, 2011, at 4:55 PM, Ali Saidi wrote: > >

Re: [m5-dev] Review Request: ARM: Fix checkpoint restoration into O3 CPU and the way O3 switchCpu works.

2011-03-30 Thread Gabe Black
> On 2011-03-30 15:38:14, Gabe Black wrote: > > I'm not sure this is right yet. Won't it only copy the USR registers now > > and leave out all the other modes? Also, is there anything wrong with > > reading the CPSR, changing the mode, and then writing it back? > > Ali Saidi wrote: > No, N

Re: [m5-dev] Review Request: ARM: Fix checkpoint restoration into O3 CPU and the way O3 switchCpu works.

2011-03-30 Thread Ali Saidi
> On 2011-03-30 15:38:14, Gabe Black wrote: > > I'm not sure this is right yet. Won't it only copy the USR registers now > > and leave out all the other modes? Also, is there anything wrong with > > reading the CPSR, changing the mode, and then writing it back? > > Ali Saidi wrote: > No, N

Re: [m5-dev] Review Request: ARM: Fix checkpoint restoration into O3 CPU and the way O3 switchCpu works.

2011-03-30 Thread Gabe Black
> On 2011-03-30 15:38:14, Gabe Black wrote: > > I'm not sure this is right yet. Won't it only copy the USR registers now > > and leave out all the other modes? Also, is there anything wrong with > > reading the CPSR, changing the mode, and then writing it back? > > Ali Saidi wrote: > No, N

Re: [m5-dev] Review Request: ARM: Fix checkpoint restoration into O3 CPU and the way O3 switchCpu works.

2011-03-30 Thread Ali Saidi
> On 2011-03-30 15:38:14, Gabe Black wrote: > > I'm not sure this is right yet. Won't it only copy the USR registers now > > and leave out all the other modes? Also, is there anything wrong with > > reading the CPSR, changing the mode, and then writing it back? No, NumIntRegs is all the regist

Re: [m5-dev] Review Request: ARM: Fix checkpoint restoration into O3 CPU and the way O3 switchCpu works.

2011-03-30 Thread Gabe Black
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/620/#review1049 --- I'm not sure this is right yet. Won't it only copy the USR registers now

[m5-dev] Review Request: ARM: Fix checkpoint restoration into O3 CPU and the way O3 switchCpu works.

2011-03-30 Thread Ali Saidi
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/620/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke