Re: [m5-dev] Review Request: O3: Cleanup the commitInfo comm struct.

2011-03-02 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/510/#review923 --- Ship it! Thanks, Ali! - Steve On 2011-02-25 21:04:59, Ali Saidi wrote:

Re: [m5-dev] Review Request: O3: Cleanup the commitInfo comm struct.

2011-02-27 Thread Ali Saidi
> On 2011-02-26 16:48:07, Gabe Black wrote: > > I don't see anything obviously wrong here, although I'm sure it wouldn't be > > hard to slip a bug into this code accidentally. Please be sure to run all > > the regressions just in case. They all run. I was very careful when I did it, so I belie

Re: [m5-dev] Review Request: O3: Cleanup the commitInfo comm struct.

2011-02-26 Thread Gabe Black
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/510/#review908 --- I don't see anything obviously wrong here, although I'm sure it wouldn't b

[m5-dev] Review Request: O3: Cleanup the commitInfo comm struct.

2011-02-25 Thread Ali Saidi
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/510/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke