Re: [m5-dev] Review Request: SimpleCPU: Allow Simple CPUs to warm a branch predictor by creating a pointer

2010-07-11 Thread Steve Reinhardt
I think it's fine like it is. Gabe is rightly concerned that some parts of SimpleCPU are not so simple anymore, particularly timing.cc, but your change doesn't impact those parts so I don't see a problem with it. Steve On Sun, Jul 11, 2010 at 11:01 AM, Timothy M Jones tjon...@inf.ed.ac.uk

Re: [m5-dev] Review Request: SimpleCPU: Allow Simple CPUs to warm a branch predictor by creating a pointer

2010-07-10 Thread Gabe Black
I haven't looked at the code yet, but I'm wary of unsimplifying the simple CPU. It's been headed that way anyway, but just as much as functionally correct execution required. I'd like to see us resimplify it somehow instead. I'm not familiar with SMARTS, but would you be able to have some short