Re: [m5-dev] Review Request: ThreadContext suspension / activation in O3 SMT - nanosleep syscall

2010-07-29 Thread Gabriel Michael Black
According to the linux kernel sources: #define _STRUCT_TIMESPEC struct timespec { time_t tv_sec; /* seconds */ longtv_nsec;/* nanoseconds */ }; #endif It basically depends on sizeof(long) for each ISA. If all ISAs supported are 64bit it can be moved to I

Re: [m5-dev] Review Request: ThreadContext suspension / activation in O3 SMT - nanosleep syscall

2010-07-29 Thread Gabriel Michael Black
It's fine with me, but we'd need to be really careful the semantics (64 bit vs. 32 bit operands, flags, etc.) are translated correctly. If a syscall isn't there at all it's obvious why it's not going to work, but if it is there and slightly wrong it'd be a lot harder to figure out what's wr

Re: [m5-dev] Review Request: ThreadContext suspension / activation in O3 SMT - nanosleep syscall

2010-07-29 Thread Ioannis Ilkos
> On 2010-07-29 08:46:47, Steve Reinhardt wrote: >> Thanks! Just a couple minor things... >> >> - Did you test this with the other CPU models besides O3? I'm guessing you >> did and O3 was the only one that broke, but I just wanted to verify that. >> If you are referring to the SMT contexts,

Re: [m5-dev] Review Request: ThreadContext suspension / activation in O3 SMT - nanosleep syscall

2010-07-29 Thread Ioannis Ilkos
> On 2010-07-29 08:46:47, Steve Reinhardt wrote: > > Thanks! Just a couple minor things... > > > > - Did you test this with the other CPU models besides O3? I'm guessing you > > did and O3 was the only one that broke, but I just wanted to verify that. > > If you are referring to the SMT cont

Re: [m5-dev] Review Request: ThreadContext suspension / activation in O3 SMT - nanosleep syscall

2010-07-29 Thread Ioannis Ilkos
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/68/ --- (Updated 2010-07-29 13:01:13.137646) Review request for Default. Summary ---

Re: [m5-dev] Review Request: ThreadContext suspension / activation in O3 SMT - nanosleep syscall

2010-07-29 Thread Timothy Jones
> On 2010-07-29 08:46:47, Steve Reinhardt wrote: > > src/arch/alpha/linux/process.cc, line 470 > > > > > > This is a broader question (not just for Ioannis): does it make sense > > to proactively add this to the syscall tables f

Re: [m5-dev] Review Request: ThreadContext suspension / activation in O3 SMT - nanosleep syscall

2010-07-29 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/68/#review115 --- Thanks! Just a couple minor things... - Did you test this with the other

Re: [m5-dev] Review Request: ThreadContext suspension / activation in O3 SMT - nanosleep syscall

2010-07-29 Thread Ali Saidi
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/68/#review112 --- Looks fine to me... anyone else? - Ali On 2010-07-29 07:59:26, Ioannis I

[m5-dev] Review Request: ThreadContext suspension / activation in O3 SMT - nanosleep syscall

2010-07-29 Thread Ioannis Ilkos
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/68/ --- Review request for Default. Summary --- This is a patch fixing the ThreadContex

[m5-dev] Review Request: ThreadContext suspension / activation in O3 SMT - nanosleep syscall

2010-07-29 Thread Ioannis Ilkos
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/68/ --- Review request for Default. Summary --- This is a patch fixing the ThreadContex