Re: [Gen-art] Genart last call review of draft-ietf-idr-bgp-prefix-sid-21

2018-06-13 Thread Peter Yee
Acee, I’m fine with leaving out positive. I was actually trying to cover the case where someone might interpret the TLV definition to allow zero SRGBs. It’s nonsensical, of course, to do so. -Peter On Jun 13, 2018, at 7:08 AM, Acee Lindem (acee) wrote: Hi Pe

Re: [Gen-art] Genart last call review of draft-ietf-idr-bgp-prefix-sid-21

2018-06-13 Thread Acee Lindem (acee)
Hi Peter, Thanks for thoroughly reviewing this document again and finding the nits. I incorporated all your comments other than adding "positive" as while it is more precise, it reads better without it and we don't want to imply that a TLV length could ever be negative. See attached diff. Than

[Gen-art] Genart last call review of draft-ietf-idr-bgp-prefix-sid-21

2018-06-13 Thread Peter Yee
Reviewer: Peter Yee Review result: Ready with Nits I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more inf