Re: [Gen-art] Gen-ART and OPS-Dir review of draft-ietf-json-text-sequence-09

2014-12-09 Thread Matthew Kerwin
On 10 December 2014 at 10:49, Nico Williams wrote: > > (yes, I think this should be a 'should', not a 'SHOULD'). > > ​Not an 'ought to'?​ -- Matthew Kerwin http://matthew.kerwin.net.au/ ___ Gen-art mailing list Gen-art@ietf.org https://www.ietf.o

Re: [Gen-art] Gen-ART and OPS-Dir review of draft-ietf-json-text-sequence-09

2014-12-09 Thread Black, David
This looks good, and the explanation of what's going on (numbers, 'true', 'false' and 'null' lack delimiters) is a useful addition. One small nit: 'truefales' is not two top-level values, 'true', and 'false'; it is simply not a valid JSON text. truefales -> truefalse Thanks, --D

Re: [Gen-art] Gen-ART and OPS-Dir review of draft-ietf-json-text-sequence-09

2014-12-09 Thread Nico Williams
On Wed, Dec 10, 2014 at 10:52:22AM +1000, Matthew Kerwin wrote: > On 10 December 2014 at 10:49, Nico Williams wrote: > > (yes, I think this should be a 'should', not a 'SHOULD'). > > Not an 'ought to'? I'll take that. ___ Gen-art mailing list Gen-art@

Re: [Gen-art] Gen-ART and OPS-Dir review of draft-ietf-json-text-sequence-09

2014-12-09 Thread Nico Williams
On Tue, Dec 09, 2014 at 06:49:35PM +, Black, David wrote: > > So I think we really do need to say something about top-level numbers > > (and true, false, and null), namely: that they must be delimited by > > whitespace, that '1234' is not a valid sequence element because > > the number may have

Re: [Gen-art] Gen-ART and OPS-Dir review of draft-ietf-json-text-sequence-09

2014-12-09 Thread Black, David
> So I think we really do need to say something about top-level numbers > (and true, false, and null), namely: that they must be delimited by > whitespace, that '1234' is not a valid sequence element because > the number may have been truncated. (Ditto 'true', since the > intended text could have

Re: [Gen-art] Gen-ART and OPS-Dir review of draft-ietf-json-text-sequence-09

2014-12-09 Thread Nico Williams
On Tue, Dec 09, 2014 at 04:41:12PM +, Black, David wrote: > [A] JSON text parse failures > > [...] > > Your alternative wording "whenever the JSON text parse fails, ..." is fine. OK. > [D] Truncation > > > A missing terminating LF is not a problem for strings, arrays, or > > objects. I see

Re: [Gen-art] Gen-ART and OPS-Dir review of draft-ietf-json-text-sequence-09

2014-12-09 Thread Black, David
Nico, Thanks for the comprehensive response. I've excerpted a few things for further comment - I'm fine with the proposed actions for anything not mentioned here. [A] JSON text parse failures > >If parsing of such an octet string as a JSON text fails, and the > >octet string is followed

Re: [Gen-art] Gen-ART and OPS-Dir review of draft-ietf-json-text-sequence-09

2014-12-08 Thread Nico Williams
On Fri, Dec 05, 2014 at 02:51:04PM +, Black, David wrote: > This is a combined Gen-ART and OPS-Dir review. Boilerplate for both follows > ... Thanks you. > Minor issues: > > [A] Section 2.1: > >If parsing of such an octet string as a JSON text fails, the parser >SHOULD nonetheless

Re: [Gen-art] Gen-ART and OPS-Dir review of draft-ietf-json-text-sequence-09

2014-12-07 Thread Pete Resnick
On 12/5/14 4:38 PM, Barry Leiba wrote: Hi, David. One note on your review: idnits didn't like the reference to RFC 20 for ASCII: ** Downref: Normative reference to an Unknown state RFC: RFC 20 RFC 5234 (ABNF) uses this, which looks like a better reference: [US-ASCII] American

Re: [Gen-art] Gen-ART and OPS-Dir review of draft-ietf-json-text-sequence-09

2014-12-07 Thread Patrik Fältström
All, Many definitions in this document have been specified in the form of 1:1 mappings of Unicode code points to single bytes. This include the record separator and for example definitions of the string "false" in the form of five octets. This is ok if the encoding used for Unicode is UTF-8, a

Re: [Gen-art] Gen-ART and OPS-Dir review of draft-ietf-json-text-sequence-09

2014-12-05 Thread Black, David
Ok, it is a nit, as is much of what idnits produces ;-). I have no problem ignoring idnits on this one ... Thanks, --David > -Original Message- > From: barryleiba.mailing.li...@gmail.com > [mailto:barryleiba.mailing.li...@gmail.com] On Behalf Of Barry Leiba > Sent: Friday, December 05, 20

Re: [Gen-art] Gen-ART and OPS-Dir review of draft-ietf-json-text-sequence-09

2014-12-05 Thread Barry Leiba
Hi, David. One note on your review: > idnits didn't like the reference to RFC 20 for ASCII: > > ** Downref: Normative reference to an Unknown state RFC: RFC 20 > > RFC 5234 (ABNF) uses this, which looks like a better reference: > >[US-ASCII] American National Standards Institute, "Coded

[Gen-art] Gen-ART and OPS-Dir review of draft-ietf-json-text-sequence-09

2014-12-05 Thread Black, David
This is a combined Gen-ART and OPS-Dir review. Boilerplate for both follows ... I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at: . Please resolve these comments along with any other Last