Hello Allen,
I looked at last patch and personally I don't see any major issue, perhaps
JVM flags, URLs and configuration keys might be better to define as
environment variables if you want to reduce the length of the lines but I
think legibility is more important.
cheers,
esteban.
--
Cloudera,
Allen, et. al.,
I'm not sure how up to date that checklist is, but imposing such a small
size on cmd arguments seems incredibly short sighted. I'm pretty sure that
it is not a generally accepted limit. I've seen MANY Hadoop processes
require lengthy CLASS_PATHS that were easily over 240 chars.
Hey Allen,
I am not a shell scripting expert but I have written few and used/seen many
from including top 3 enterprise software giants. I don't think everyone
sticks to 80 char guidelines, may be this is remnant of the old 80 char
terminals. I prefer long descriptive names for the env vars (or var
Hey folks:
Deep linked by http://wiki.apache.org/hadoop/CodeReviewChecklist is the
rule that line length should be ideally maximum 80 chars. (Sun coding
guidelines.) In general, it's a good idea and it works for many many
languages...
Now the caveat.
As most of you know, I've been ha
