There's DEVNOTES.txt that has all the info for the build. Hope it helps.
Thanks!
Cos
On Sat, Jul 18, 2015 at 01:40PM, Justin Mclean wrote:
> Hi,
>
> I’ve having little trouble compiling it, but everything else checks out
> fine. Are there instructions anywhere on how to compile/what’s required
On Fri, Jul 17, 2015 at 02:51PM, Marvin Humphrey wrote:
> Hi Cos,
>
> Thanks for providing a thoughtfully documented review.
>
> On Fri, Jul 17, 2015 at 2:24 PM, Konstantin Boudnik wrote:
> > +1 (binding)
>
> > Please consider fixing in the next release:
> > - sha checksum is formatted in a wa
Signature file looks good
Hashes are checked (NOTE next time probably use sha512)
NOTICE file looks good
LICENSE file looks good
DISCLAIMER exists
No 3rd party exes.
+1 (binding)
On Thu, Jul 16, 2015 at 9:22 PM, Luke Han wrote:
> Hi all,
>
> The Apache Kylin community has voted on and approved
Hi,
+1 binding
I checked:
- source release contains incubating
- signatures and md5 hash are good
- DISCLAIMER exists
- LICENSE and NOTICE correct
- No unexpected binaries in source release
- All source files contain Apache headers
- Can compile from source (although had some difficultly in doing
Justin thank you for taking the time to evaluate the release.
On Fri, Jul 17, 2015 at 10:57 PM, Tim Williams wrote:
> Thanks for taking the time to review Justin, we appreciate it.
>
> On Fri, Jul 17, 2015 at 8:01 PM, Justin Mclean
> wrote:
> > Hi,
> >
> > Sorry but it’s -1 (binding) until the
Due to various issues we are canceling the vote for release.
Aaron
On Sat, Jul 18, 2015 at 5:53 PM, Aaron McCurry wrote:
> Justin thank you for taking the time to evaluate the release.
>
> On Fri, Jul 17, 2015 at 10:57 PM, Tim Williams
> wrote:
>
>> Thanks for taking the time to review Justin,
Hi,
> I think we just missed it, based on the example, I don't think we can
> use that escape-clause/rationale for its inclusion. We should take it
> back to the dev list at this point.
Hope it easily replaceable with something that’s more Apache license compatable.
> Yeah, these were just to d
Hi,
+1 binding
Please fix the LICENSE/NOTICE issues are fixed for next release. Given
everything involved is Apache comparable it's more a documentation issue but
still important to get right. If you need a hand or need it reviewed before
your next release just ask.
The LICENSE/NOTICE issues
On 14/07/2015 7:00 AM, Justin Mclean wrote:
Hi,
We don't bundle the source from any of those libraries true, but we do generate
sources as part of our build using ANTLR and we do bundle the class files from
the ANLTR and ASM projects in some of our jars and we do bundle the jars from
some of
