[CANCEL][VOTE] Release Apache Celeborn(Incubating) 0.3.1-incubating-rc2

2023-09-19 Thread Cheng Pan
Cancel this vote because of the license issue. See details in the vote thread: https://lists.apache.org/thread/8v4wy5o132rpsjync6465zztgjlf6h5p Thanks to all who participated in the vote, I’m going to fix the issue and prepare the next RC ASAP. Thanks, Cheng Pan

Re: [VOTE] Release Apache Celeborn(Incubating) 0.3.1-incubating-rc2

2023-09-19 Thread Cheng Pan
Thanks for the advice, will update soon. Thanks, Cheng Pan > On Sep 19, 2023, at 20:11, PJ Fanning wrote: > > I think it would be simpler to use the standard protobuf license. Just > one file, including its copyright. > > https://github.com/protocolbuffers/protobuf/blob/main/LICENSE > > On

Re: [VOTE] Release Apache Celeborn(Incubating) 0.3.1-incubating-rc2

2023-09-19 Thread PJ Fanning
I think it would be simpler to use the standard protobuf license. Just one file, including its copyright. https://github.com/protocolbuffers/protobuf/blob/main/LICENSE On Tue, 19 Sept 2023 at 12:45, Cheng Pan wrote: > > PJ Fanning, both LICENSE-BSD-3.txt and LICENSE-BSD-3.txt are applied to >

Re: [VOTE] Release Apache Celeborn(Incubating) 0.3.1-incubating-rc2

2023-09-19 Thread Cheng Pan
PJ Fanning, both LICENSE-BSD-3.txt and LICENSE-BSD-3.txt are applied to protobuf-java, it was mentioned at the end of client-spark/spark-3-shaded/LICENSE, please let me know if you have a better idea of how to document clearly. > BSD 3-clause > See license/LICENSE-BSD-3.txt for details. >

Re: [VOTE] Release Apache Celeborn(Incubating) 0.3.1-incubating-rc2

2023-09-19 Thread Cheng Pan
Thanks, Duo, will have a try. Thanks, Cheng Pan > On Sep 19, 2023, at 19:30, 张铎(Duo Zhang) wrote: > > I checked the pom for spark-3-shaded > > https://github.com/apache/incubator-celeborn/blob/main/client-spark/spark-3-shaded/pom.xml > > You could try adding these transformers to the shade

Re: [VOTE] Release Apache Celeborn(Incubating) 0.3.1-incubating-rc2

2023-09-19 Thread PJ Fanning
I'll have a look around to see if there are other issues. With the BSD license mentioned in the client-spark/spark-3-shaded LICENSE, could it be adjusted to say which libs it applies to?

Re: [VOTE] Release Apache Celeborn(Incubating) 0.3.1-incubating-rc2

2023-09-19 Thread Duo Zhang
I checked the pom for spark-3-shaded https://github.com/apache/incubator-celeborn/blob/main/client-spark/spark-3-shaded/pom.xml You could try adding these transformers to the shade plugin to see if it helps false Cheng Pan 于2023年9月19日周二 19:17写道: > > Hi PJ Fanning, > >

Re: [VOTE] Release Apache Celeborn(Incubating) 0.3.1-incubating-rc2

2023-09-19 Thread Cheng Pan
Hi PJ Fanning, Thanks for pointing out this issue, it was considered but seems broken recently, unfortunately. The proposed NOTICE and LICENSE files are under [1], would you mind taking a look? If it's OK, I’m going to investigate and fix the packaging issue then. Given it’s a license issue,

Re: [VOTE] Release Apache Celeborn(Incubating) 0.3.1-incubating-rc2

2023-09-19 Thread PJ Fanning
I have some concerns over the jars that are part of the release. I looked at celeborn-client-spark-3-shaded_2.12-0.3.1-incubating.jar in https://repository.apache.org/content/repositories/orgapacheceleborn-1039/org/apache/celeborn/celeborn-client-spark-3-shaded_2.12/0.3.1-incubating/ The jar

Re: [VOTE] Release Apache Celeborn(Incubating) 0.3.1-incubating-rc2

2023-09-18 Thread keyong zhou
+1 (non-binding) I checked - git commit hash is correct. - links are valid. - "incubating" is in the name. - PGP keys are good. - hashes are correct. - LICENSE looks good. - NOTICE looks good. - DISCLAIMER exists. - build success from source code (macOS). ``` ./build/make-distribution.sh

Re: [VOTE] Release Apache Celeborn(Incubating) 0.3.1-incubating-rc2

2023-09-15 Thread Cheng Pan
Hi, Duo, Thanks for voting and verification. > 'mvn test -Pflink-1.17', I'm not sure whether this is the correct it probably works, it’s recommended to use `build/mvn` instead of bare `mvn` to build and test, which will use or download the `mvn` with the exact `maven.version` declared in

Re: [VOTE] Release Apache Celeborn(Incubating) 0.3.1-incubating-rc2

2023-09-15 Thread Duo Zhang
+1 binding Checked sigs and sums: Matched LICENSE and NOTICE: OK DISCLAIMER: In place Built from source: ‘./build/make-distribution.sh -Pflink-1.17’, successfully generated the tarball Run UTs: 'mvn test -Pflink-1.17', I'm not sure whether this is the correct way as the README does not

[VOTE] Release Apache Celeborn(Incubating) 0.3.1-incubating-rc2

2023-09-14 Thread Cheng Pan
Hi IPMC, This is a call for a vote to release Apache Celeborn (Incubating) 0.3.1-incubating-rc2 The Apache Celeborn community has voted on and approved a proposal to release Apache Celeborn (Incubating) version 0.3.1-incubating-rc2. We now kindly request the Incubator PMC members review and vote