Re: Re: [VOTE] Release Apache Doris 0.14.0-incubating-rc03

2021-03-29 Thread 寒江雪
Hi ming wen, thanks for reply, I wil start a new vote. Ming Wen 于2021年3月29日周一 下午3:57写道: > yes, looks good to me. > > Thanks, > Ming Wen, Apache APISIX PMC Chair > Twitter: _WenMing > > > 寒江雪 于2021年3月29日周一 下午3:38写道: > > > Hi ming wen, > > Is it possible to exclude all the unit tests in our

Re: Re: [VOTE] Release Apache Doris 0.14.0-incubating-rc03

2021-03-29 Thread Ming Wen
yes, looks good to me. Thanks, Ming Wen, Apache APISIX PMC Chair Twitter: _WenMing 寒江雪 于2021年3月29日周一 下午3:38写道: > Hi ming wen, > Is it possible to exclude all the unit tests in our project source code > when packaging the release tarball ? > > Ming Wen 于2021年3月29日周一 上午10:59写道: > > > hello,

Re: Re: [VOTE] Release Apache Doris 0.14.0-incubating-rc03

2021-03-29 Thread 寒江雪
Hi ming wen, Is it possible to exclude all the unit tests in our project source code when packaging the release tarball ? Ming Wen 于2021年3月29日周一 上午10:59写道: > hello, mingyu, > These files can be in the GitHub repo, but should not be in the released > source package. > You can remove the

Re: Re: [VOTE] Release Apache Doris 0.14.0-incubating-rc03

2021-03-28 Thread Ming Wen
hello, mingyu, These files can be in the GitHub repo, but should not be in the released source package. You can remove the test-related files when packaging, this is also the usual practice. Thanks, Ming Wen, Apache APISIX PMC Chair Twitter: _WenMing 陈明雨 于2021年3月29日周一 上午10:48写道: > Hi

Re:Re: [VOTE] Release Apache Doris 0.14.0-incubating-rc03

2021-03-28 Thread 陈明雨
Hi kezhenxu94: Thanks for your apply. We have such a scenario, such as the need to test a file decompression code in a unit test. I think a reasonable way is to directly provide some small zip files for the unit test to test the decompression logic without writing a set of compression code

Re: [VOTE] Release Apache Doris 0.14.0-incubating-rc03

2021-03-28 Thread kezhenxu94
> On Mar 28, 2021, at 18:40, 陈明雨 wrote: > > Hi kezhenxu94: > > > These files are for unit tests to test the java dynamic library loading, not > some kind of "test tools". I have some further questions, where are these files come from, if their source codes are in the same repo, why not

Re:Re: [VOTE] Release Apache Doris 0.14.0-incubating-rc03

2021-03-28 Thread 陈明雨
Hi kezhenxu94: These files are for unit tests to test the java dynamic library loading, not some kind of "test tools". These files are in the code repo for a long time and also contained in our previous releases, and no one disagrees with it. So I believe it is ok for a source release. --

Re: [VOTE] Release Apache Doris 0.14.0-incubating-rc03

2021-03-27 Thread kezhenxu94@apache
Sorry my -1, I saw there are binary files in the source tar, although they’re test tools, but this is not allowed in the source release. ./fe/fe-core/src/test/resources/plugin_test/plugin_test.jar ./fe/fe-core/src/test/resources/plugin_test/test_local_plugin/auditdemo.jar > On Mar 26, 2021, at

Re:[VOTE] Release Apache Doris 0.14.0-incubating-rc03

2021-03-27 Thread 陈明雨
Here is my +1 (non-binding) -- 此致!Best Regards 陈明雨 Mingyu Chen Email: chenmin...@apache.org At 2021-03-26 12:36:06, "寒江雪" wrote: >Hi all, > >Please review and vote on Apache Doris 0.14.0-incubating-rc03 release. > >Apache Doris is an MPP-based interactive SQL data warehousing for

[VOTE] Release Apache Doris 0.14.0-incubating-rc03

2021-03-25 Thread 寒江雪
Hi all, Please review and vote on Apache Doris 0.14.0-incubating-rc03 release. Apache Doris is an MPP-based interactive SQL data warehousing for reporting and analysis. The Apache Doris community has voted on and approved this release: