Thanks Owen,
BasicResponse has the header text in it but for some reason it ended up
after the imports. That must be why RAT didn't fail with an error. We
will move the license header to the top of the file.
Kevin.
On 12/2/13 12:56 PM, Owen O'Malley wrote:
+1 on the RC. I checked the
Sebb,
Thanks for your careful review. I'd like your continued insight into
two specific issues that you have raised.
WRT the NOTICE files in root vs gatway-release/home, this is actually an
issue that I struggled with when laying things out initially. We
certainly don't include the source
Duplicated message.
I already responded to the other copy in the thread
On 2 December 2013 20:11, Kevin Minder kevin.min...@hortonworks.com wrote:
Sebb,
Thanks for your careful review. I'd like your continued insight into two
specific issues that you have raised.
WRT the NOTICE files in
+1 on the RC. I checked the signatures, looked for license headers, built,
and ran unit tests.
For the next release, please add a license header
to
gateway-shell/src/main/java/org/apache/hadoop/gateway/shell/BasicResponse.java.
On Wed, Nov 27, 2013 at 4:26 PM, Devaraj Das d...@hortonworks.com
On further inspection, I see the header is there, but not at the top of the
file. Please move it in a future release.
-- Owen
On Mon, Dec 2, 2013 at 9:56 AM, Owen O'Malley omal...@apache.org wrote:
+1 on the RC. I checked the signatures, looked for license headers, built,
and ran unit tests.
Will do.
Thank you for the review and vote, Owen!
On Mon, Dec 2, 2013 at 1:09 PM, Owen O'Malley omal...@apache.org wrote:
On further inspection, I see the header is there, but not at the top of the
file. Please move it in a future release.
-- Owen
On Mon, Dec 2, 2013 at 9:56 AM, Owen
On 20 November 2013 16:09, larry mccay larry.mc...@gmail.com wrote:
Hello All,
This is a call for a vote on Apache Knox Gateway 0.3.1 incubating.
A vote was held on developer mailing list and it passed with 3 +1's, and 0
-1's or +0's and now
requires a vote on general@incubator.apache.org.
Thank you again, Sebb.
I am noting your new findings here and will fix them asap for the next
release.
I assume that your lack of an actual vote indicates that these fixes can be
made in the next release and that you are not indicating that this RC
should be abandoned. Please let me know if this
On 2 December 2013 20:17, Larry McCay lmc...@hortonworks.com wrote:
Thank you again, Sebb.
I am noting your new findings here and will fix them asap for the next
release.
I assume that your lack of an actual vote indicates that these fixes can be
made in the next release and that you are
Sebb,
Thanks for your careful review. I'd like your continued insight into two
specific issues that you have raised.
WRT the NOTICE files in root vs gatway-release/home, this is actually an
issue that I struggled with when laying things out initially. We certainly
don't include the source for
On 2 December 2013 20:44, Kevin Minder kmin...@apache.org wrote:
Sebb,
Thanks for your careful review. I'd like your continued insight into two
specific issues that you have raised.
WRT the NOTICE files in root vs gatway-release/home, this is actually an
issue that I struggled with when
Thank you for your review and insight.
We are canceling this vote to address the NOTICE files and other issues and
then create a new release candidate.
On Mon, Dec 2, 2013 at 4:29 PM, sebb seb...@gmail.com wrote:
On 2 December 2013 20:44, Kevin Minder kmin...@apache.org wrote:
Sebb,
+1 on the RC. Downloaded, built and ran unit tests.
On Mon, Nov 25, 2013 at 8:00 PM, larry mccay lmc...@apache.org wrote:
Hello All -
Just to follow up on this thread, we will have these NOTICES file issues
corrected in the next release and assume that this VOTE will continue in
the
Hello All -
Just to follow up on this thread, we will have these NOTICES file issues
corrected in the next release and assume that this VOTE will continue in
the absence of a -1 vote.
Thank you again, for the insight here.
--larry
On Sat, Nov 23, 2013 at 10:40 AM, larry mccay
Hi Dave -
I'm sorry, we have one Mentor +1 on the PPMC vote.
We will be sure to list those going forward.
Thanks,
--larry
On Fri, Nov 22, 2013 at 7:23 PM, Dave Fisher dave2w...@comcast.net wrote:
How many +1 IPMC Binding Votes did you have from your Mentors?
Putting this information
Hi Sebb -
Thank you for your review and insight!
We will make these changes immediately and insure that they are correct
going forward.
Do these issues require a new release candidate - or would that only be
indicated by a -1?
thanks,
--larry
On Sat, Nov 23, 2013 at 10:23 AM, sebb
On 20 November 2013 16:09, larry mccay larry.mc...@gmail.com wrote:
Hello All,
This is a call for a vote on Apache Knox Gateway 0.3.1 incubating.
A vote was held on developer mailing list and it passed with 3 +1's, and 0
-1's or +0's and now
requires a vote on general@incubator.apache.org.
+1. Looked over the LICENSE, NOTICE, and DISCLAIMER files. Checked the
signatures on the source release. Did mvn install on the package to make sure
it built.
Alan.
On Nov 20, 2013, at 8:09 AM, larry mccay wrote:
Hello All,
This is a call for a vote on Apache Knox Gateway 0.3.1
How many +1 IPMC Binding Votes did you have from your Mentors?
Putting this information clearly in the thread is very helpful.
Regards,
Dave
On Nov 20, 2013, at 8:09 AM, larry mccay wrote:
Hello All,
This is a call for a vote on Apache Knox Gateway 0.3.1 incubating.
A vote was held on
Hello All,
This is a call for a vote on Apache Knox Gateway 0.3.1 incubating.
A vote was held on developer mailing list and it passed with 3 +1's, and 0
-1's or +0's and now
requires a vote on general@incubator.apache.org.
The [VOTE] thread can be found at:
20 matches
Mail list logo
