Re: [VOTE] Release Apache StreamPark(Incubating) 2.0.0-RC2

2023-01-28 Thread Huajie Wang
Thanks for review and feedback, streampark project does included the source code of the maven-wrapper project, We will add the license information of maven-wrapper to LICENSE file. Best, Huajie Wang kezhenxu94 于2023年1月28日周六 22:15写道: > > > On Jan 28, 2023, at 21:43, Justin Mclean > wrote: >

Re: [VOTE] Release Apache StreamPark(Incubating) 2.0.0-RC2

2023-01-28 Thread kezhenxu94
> On Jan 28, 2023, at 21:43, Justin Mclean wrote: > > Hi, > >> 2. NOTICE is OK but I’m not sure if the maven wrapper code is included in >> the source release? >> >> the maven wrapper code is not included in the source code[1] But I can see the maven wrapper scripts are included in the sourc

Re: [VOTE] Release Apache StreamPark(Incubating) 2.0.0-RC2

2023-01-28 Thread Calvin Kirs
On Sat, Jan 28, 2023 at 9:52 PM Huajie Wang wrote: > > Hi Justin: > > Thanks for your feedback, it is really redundant to mention in the NOTICE > file, We will fix it. I checked the source package and I'm pretty sure your mvnw.cmd and mvnw files are sourced from the maven-wrapper project. > > > Ju

Re: [VOTE] Release Apache StreamPark(Incubating) 2.0.0-RC2

2023-01-28 Thread Huajie Wang
Hi Justin: Thanks for your feedback, it is really redundant to mention in the NOTICE file, We will fix it. Justin Mclean 于2023年1月28日周六 21:44写道: > Hi, > > > 2. NOTICE is OK but I’m not sure if the maven wrapper code is included in > > the source release? > > > > the maven wrapper code is not in

Re: [VOTE] Release Apache StreamPark(Incubating) 2.0.0-RC2

2023-01-28 Thread Justin Mclean
Hi, > 2. NOTICE is OK but I’m not sure if the maven wrapper code is included in > the source release? > > the maven wrapper code is not included in the source code[1] Then why is it mention in the NOTICE file? Kind Regards, Justin ---

Re: [VOTE] Release Apache StreamPark(Incubating) 2.0.0-RC2

2023-01-28 Thread Huajie Wang
Hi Justin, Thanks for your review, we'll fix the problems you mentioned. We need to fix some license related issues: 1. LICENSE is missing license information for fonts under we'll remove google-fonts from the front-end module, 2. NOTICE is OK but I’m not sure if the maven wrapper code is inc

Re: [VOTE] Release Apache StreamPark(Incubating) 2.0.0-RC2

2023-01-28 Thread Huajie Wang
> > Hi Justin, > > Thanks for your review, we'll fix the problems you mentioned. > > We need to fix some license related issues: > > 1. LICENSE is missing license information for fonts under > > We'll remove google-fonts from the front-end module, > > > 2. NOTICE is OK but I’m not sure if the maven

Re: [VOTE] Release Apache StreamPark(Incubating) 2.0.0-RC2

2023-01-28 Thread Justin Mclean
Hi, Sorry I’it -1 binding from me. I checked in the source release: - incubating in name - signatures and hashes are fine - LICENSE is missing license information for fonts under [1]. It looks like this is this font [2] licensed under the Open Font License a category B license. [3] Normally thi

Re: [VOTE] Release Apache StreamPark(Incubating) 2.0.0-RC2

2023-01-27 Thread Shaokang Lv
+1 (binding) I checked: 1. All download links are valid 2.The source and distribution packages already exist 3. Checksum and signature are OK 4. LICENSE and NOTICE are exist and NOTICE file year is ok 5. Build successfully on MacOs M1 陈卓宇 于2023年1月28日周六 15:17写道: > +1 (bindin

Re: [VOTE] Release Apache StreamPark(Incubating) 2.0.0-RC2

2023-01-27 Thread 陈卓宇
+1 (binding) I checked: 1. All download links are valid 2.The source and distribution packages already exist 3. Checksum and signature are OK 4. LICENSE and NOTICE are exist and NOTICE file year is ok 5. Build successfully on MacOs Huajie Wang 于2023年1月28日周六 12:53写道: > Hello

[VOTE] Release Apache StreamPark(Incubating) 2.0.0-RC2

2023-01-27 Thread Huajie Wang
Hello Incubator Community: This is a call for a vote to release Apache StreamPark(Incubating) version 2.0.0-RC2 The Apache StreamPark community has voted on and approved a proposal to release Apache StreamPark(Incubating) version 2.0.0-RC2 We now kindly request the Incubator PMC members review a