Re: [VOTE] Release Apache Dubbo (Incubating) 2.7.0 [RC2]

2019-01-29 Thread Huxing Zhang
Hi, On Tue, Jan 29, 2019 at 4:27 PM Justin Mclean wrote: > > Hi, > > > According to Netty's notice file[1], I've update copyright to 2014. > > Please revert back, while a minor change, in general you should never ever > change 3rd party header files without their permission. I checked the sourc

Re: [VOTE] Release Apache Dubbo (Incubating) 2.7.0 [RC2]

2019-01-29 Thread 吴晟 Sheng Wu
, wusheng1108 -- Original -- From: "hux...@apache.org"; Date: Tue, Jan 29, 2019 10:03 AM To: "Incubator General"; Subject: Re: [VOTE] Release Apache Dubbo (Incubating) 2.7.0 [RC2] Hi community, Dubbo 2.7.0 RC2 is still waiting for 1 more bi

Re: [VOTE] Release Apache Dubbo (Incubating) 2.7.0 [RC2]

2019-01-29 Thread Justin Mclean
Hi, > According to Netty's notice file[1], I've update copyright to 2014. Please revert back, while a minor change, in general you should never ever change 3rd party header files without their permission. Thanks, Justin

Re: [VOTE] Release Apache Dubbo (Incubating) 2.7.0 [RC2]

2019-01-29 Thread Huxing Zhang
Hi community, 72 hours has passed, the vote has passed with 3 +1 binding votes and no -1 binding vote. +1 binding: * Justin Mclean * Gosling Von * Willem Jiang I will proceed to publish the artifacts. Thanks for everyone who voted! On Thu, Jan 24, 2019 at 10:28 PM Huxing Zhang wrote: > > Hel

Re: [VOTE] Release Apache Dubbo (Incubating) 2.7.0 [RC2]

2019-01-29 Thread Huxing Zhang
Hi, On Sat, Jan 26, 2019 at 9:45 AM Justin Mclean wrote: > > Hi, > > +1 binding but there a few minor issues that need looking into > > I checked: > - incubating in release name > - signatures and hashes good > - DISCLAIMER exists > - LICENSE may have a couple of minor issue (see below) > - NOTIC

Re: [VOTE] Release Apache Dubbo (Incubating) 2.7.0 [RC2]

2019-01-28 Thread Willem Jiang
+1. Checked the github tag with the source code. Checked the signed key and can build from the source. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Thu, Jan 24, 2019 at 10:28 PM Huxing Zhang wrote: > > Hello Incubator Community, > > The Apache Dubbo community has voted on and approved

Re: [VOTE] Release Apache Dubbo (Incubating) 2.7.0 [RC2]

2019-01-28 Thread Huxing Zhang
Hi community, Dubbo 2.7.0 RC2 is still waiting for 1 more binding vote to get it passed. Would you please help to review and vote for the candidate? Any help is greatly appreciated! On Thu, Jan 24, 2019 at 10:28 PM Huxing Zhang wrote: > > Hello Incubator Community, > > The Apache Dubbo community

Re: [VOTE] Release Apache Dubbo (Incubating) 2.7.0 [RC2]

2019-01-27 Thread Justin Mclean
Hi, That probably doesn't need to be added. Dependancues do not need to be listed in LICENCE or NOTICE. Only 3rd party software bundled in the release needs to be mentioned. Thanks, Justin On Sun, 27 Jan 2019, 18:50 Gosling Von +1 binding > > I focused on the license and notice files since som

Re: [VOTE] Release Apache Dubbo (Incubating) 2.7.0 [RC2]

2019-01-27 Thread Gosling Von
+1 binding I focused on the license and notice files since some podling projects have many minor problems in here. In addition to the problems as Justin said. I have found some of the non-optional dependency modules such as javaassit, spring-context not exist in NOTICE file. Please fix it in t

Re: [VOTE] Release Apache Dubbo (Incubating) 2.7.0 [RC2]

2019-01-25 Thread Justin Mclean
Hi, +1 binding but there a few minor issues that need looking into I checked: - incubating in release name - signatures and hashes good - DISCLAIMER exists - LICENSE may have a couple of minor issue (see below) - NOTICE good - No unexpected binary in release - A few minor header issues - Can comp

[VOTE] Release Apache Dubbo (Incubating) 2.7.0 [RC2]

2019-01-24 Thread Huxing Zhang
Hello Incubator Community, The Apache Dubbo community has voted on and approved a proposal to release Apache Dubbo (Incubating) version 2.7.0. We now kindly request the Incubator PMC members review and vote on this incubator release. Apache Dubbo™ (incubating) is a high-performance, java based,