+1 but
it was discussed before, but thirdeye is not included in the source release
https://github.com/apache/incubator-pinot/blob/master/pinot-distribution/pinot-source-assembly.xml#L39
- incubating in name
- signature and hash fine
- DISCLAIMER is fine
- LICENSE and NOTICE are fine
- No unexpect
Hi Felix,
Thanks for the feedback! Sorry I don't have the context on including thirdeye
into the pinot open source release. Could you share the related email thread?
If it's not urgent, maybe we can add some notes in pinot release page
(https://github.com/apache/incubator-pinot/releases), so th
It was discussed several times in private@pinot, we can take it from there.
It will probably best if one of you simply edit that line right now in the
git repo so we don’t get into this again in 0.7 release.
On Wed, Nov 11, 2020 at 10:58 AM Jialiang Li wrote:
> Hi Felix,
>
> Thanks for the fee
+1
On Wed, Nov 11, 2020 at 6:09 PM Felix Cheung wrote:
> It was discussed several times in private@pinot, we can take it from
> there.
>
> It will probably best if one of you simply edit that line right now in the
> git repo so we don’t get into this again in 0.7 release.
>
>
> On Wed, Nov 11,
HI -
+1 (binding)
All checks pass - signature, hash, incubating in name, LICENSE, NOTICE on both
repositories.
I recommend that you ask your Mentors how to use Apache Rat
(https://creadur.apache.org/rat/index.html) and add a .rat-excludes file. This
would make license checking much easier.
P
+1
On Thu, 12 Nov 2020 at 12:09, Felix Cheung wrote:
> It was discussed several times in private@pinot, we can take it from
> there.
>
> It will probably best if one of you simply edit that line right now in the
> git repo so we don’t get into this again in 0.7 release.
>
>
> On Wed, Nov 11, 202
