Re: [gentoo-dev] [PATCH] ebuild-writing/variables: better describe ROOT

2016-05-15 Thread Mike Gilbert
On Sat, May 14, 2016 at 5:35 PM, Göktürk Yüksek wrote: > Mike Gilbert: >> The current description of ROOT makes no sense and just confuses >> people. The new description is paraphrased from PMS. --- >> ebuild-writing/variables/text.xml | 5 +++-- 1 file changed, 3 >>

Re: [gentoo-dev] [PATCH] ebuild-writing/variables: better describe ROOT

2016-05-14 Thread Göktürk Yüksek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Mike Gilbert: > The current description of ROOT makes no sense and just confuses > people. The new description is paraphrased from PMS. --- > ebuild-writing/variables/text.xml | 5 +++-- 1 file changed, 3 > insertions(+), 2 deletions(-) > > diff

Re: [gentoo-dev] [PATCH] ebuild-writing/variables: better describe ROOT

2016-05-10 Thread Brian Dolbec
On Tue, 10 May 2016 22:40:39 -0400 Mike Gilbert wrote: > On Tue, May 10, 2016 at 9:54 PM, Brian Dolbec > wrote: > >> I agree, repoman should be catching this stuff. > >> > > > > Then Please contribute some test ebuilds for the gen-b0rk repo to > > test

Re: [gentoo-dev] [PATCH] ebuild-writing/variables: better describe ROOT

2016-05-10 Thread Mike Gilbert
On Tue, May 10, 2016 at 9:54 PM, Brian Dolbec wrote: >> I agree, repoman should be catching this stuff. >> > > Then Please contribute some test ebuilds for the gen-b0rk repo to test > repoman or any other Q/A apps with. If they fail to detect the test > ebuilds, it will give

Re: [gentoo-dev] [PATCH] ebuild-writing/variables: better describe ROOT

2016-05-10 Thread Mike Gilbert
On Tue, May 10, 2016 at 10:19 PM, Mike Gilbert wrote: > On Tue, May 10, 2016 at 9:42 PM, Mike Gilbert wrote: >>> Anywhere that you need addpredict() it also seems reasonable. The >>> v4l-dvb-saa716x ebuilds use "${ROOT}/usr/src/linux/" where EPREFIX would

Re: [gentoo-dev] [PATCH] ebuild-writing/variables: better describe ROOT

2016-05-10 Thread Mike Gilbert
On Tue, May 10, 2016 at 9:42 PM, Mike Gilbert wrote: >> Anywhere that you need addpredict() it also seems reasonable. The >> v4l-dvb-saa716x ebuilds use "${ROOT}/usr/src/linux/" where EPREFIX would >> not be a good replacement. > > Nah, usually addpredict is dealing with stuff

Re: [gentoo-dev] [PATCH] ebuild-writing/variables: better describe ROOT

2016-05-10 Thread Brian Dolbec
On Tue, 10 May 2016 21:42:19 -0400 Mike Gilbert wrote: > On Tue, May 10, 2016 at 5:25 PM, Michael Orlitzky > wrote: > > On 05/10/2016 02:28 PM, Mike Gilbert wrote: > >> On Tue, May 10, 2016 at 11:08 AM, Michael Orlitzky > >> wrote: >

Re: [gentoo-dev] [PATCH] ebuild-writing/variables: better describe ROOT

2016-05-10 Thread Mike Gilbert
On Tue, May 10, 2016 at 5:25 PM, Michael Orlitzky wrote: > On 05/10/2016 02:28 PM, Mike Gilbert wrote: >> On Tue, May 10, 2016 at 11:08 AM, Michael Orlitzky wrote: >>> We have maybe 150 ebuilds in the tree using $ROOT in src_* functions. >>> Some are bugs, but

Re: [gentoo-dev] [PATCH] ebuild-writing/variables: better describe ROOT

2016-05-10 Thread Ian Stakenvicius
On 10/05/16 05:25 PM, Michael Orlitzky wrote: > * dmraid does > > einfo "Appending pkg.m4 from system to aclocal.m4" > cat "${ROOT}"/usr/share/aclocal/pkg.m4 >>"${S}"/aclocal.m4 || \ > die "Could not append pkg.m4 I'm pretty sure dmraid was me, and that code likely predates

Re: [gentoo-dev] [PATCH] ebuild-writing/variables: better describe ROOT

2016-05-10 Thread Michael Orlitzky
On 05/10/2016 02:28 PM, Mike Gilbert wrote: > On Tue, May 10, 2016 at 11:08 AM, Michael Orlitzky wrote: >> We have maybe 150 ebuilds in the tree using $ROOT in src_* functions. >> Some are bugs, but many look OK to me. Do we really want to say "never" >> do that? > > According

Re: [gentoo-dev] [PATCH] ebuild-writing/variables: better describe ROOT

2016-05-10 Thread James Le Cuirot
On Tue, 10 May 2016 14:28:46 -0400 Mike Gilbert wrote: > On Tue, May 10, 2016 at 11:08 AM, Michael Orlitzky > wrote: > > We have maybe 150 ebuilds in the tree using $ROOT in src_* > > functions. Some are bugs, but many look OK to me. Do we really want > > to

Re: [gentoo-dev] [PATCH] ebuild-writing/variables: better describe ROOT

2016-05-10 Thread Mike Gilbert
On Tue, May 10, 2016 at 11:08 AM, Michael Orlitzky wrote: > We have maybe 150 ebuilds in the tree using $ROOT in src_* functions. > Some are bugs, but many look OK to me. Do we really want to say "never" > do that? According to PMS, it is only legal in pkg functions. Can you

Re: [gentoo-dev] [PATCH] ebuild-writing/variables: better describe ROOT

2016-05-10 Thread M. J. Everitt
On 10/05/16 16:08, Michael Orlitzky wrote: > On 05/08/2016 01:42 PM, Mike Gilbert wrote: >> The current description of ROOT makes no sense and just confuses people. >> The new description is paraphrased from PMS. > The current version is bad, but the PMS version isn't great either. > > We really

Re: [gentoo-dev] [PATCH] ebuild-writing/variables: better describe ROOT

2016-05-10 Thread Michael Orlitzky
On 05/08/2016 01:42 PM, Mike Gilbert wrote: > The current description of ROOT makes no sense and just confuses people. > The new description is paraphrased from PMS. The current version is bad, but the PMS version isn't great either. We really need examples for D, ROOT, ED, EROOT, and EPREFIX.

[gentoo-dev] [PATCH] ebuild-writing/variables: better describe ROOT

2016-05-08 Thread Mike Gilbert
The current description of ROOT makes no sense and just confuses people. The new description is paraphrased from PMS. --- ebuild-writing/variables/text.xml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ebuild-writing/variables/text.xml