Re: [gentoo-dev] [PATCH 1/4] readme.gentoo-r1.eclass: display readme if content changed (or fresh install)

2024-06-04 Thread Ionen Wolkens
On Tue, Jun 04, 2024 at 02:37:56PM -0400, Ionen Wolkens wrote: > On Tue, Jun 04, 2024 at 07:45:39PM +0200, Ulrich Mueller wrote: > > In any case, the above size considerations aren't important. My main > > point is that the code is getting way too complicated for the simple > > task of printing a f

Re: [gentoo-dev] [PATCH 1/4] readme.gentoo-r1.eclass: display readme if content changed (or fresh install)

2024-06-04 Thread Ulrich Mueller
> On Tue, 04 Jun 2024, Florian Schmaus wrote: > And yes, "docompress -x README.gentoo" would make the code mch > simpler. Go for it then. Apparently it is the lesser evil. signature.asc Description: PGP signature

Re: [gentoo-dev] [PATCH 1/4] readme.gentoo-r1.eclass: display readme if content changed (or fresh install)

2024-06-04 Thread Ionen Wolkens
On Tue, Jun 04, 2024 at 07:45:39PM +0200, Ulrich Mueller wrote: > In any case, the above size considerations aren't important. My main > point is that the code is getting way too complicated for the simple > task of printing a few lines in pkg_postinst. Have to say that this is mostly how I feel a

Re: [gentoo-dev] [PATCH 1/4] readme.gentoo-r1.eclass: display readme if content changed (or fresh install)

2024-06-04 Thread Eli Schwartz
On 6/4/24 2:28 PM, Florian Schmaus wrote: > And yes, "docompress -x README.gentoo" would make the code mch > simpler. And, as additional benefit, would help us get rid of storing > the whole content of the readme in a environment variable (which is what > readme.gentoo-r1.elcass currently d

Re: [gentoo-dev] [PATCH 1/4] readme.gentoo-r1.eclass: display readme if content changed (or fresh install)

2024-06-04 Thread Florian Schmaus
On 04/06/2024 19.45, Ulrich Mueller wrote: On Tue, 04 Jun 2024, Florian Schmaus wrote: Both is fine with me. That said, many filesystem support inline data. If I am not mistaken, then its even enabled by default for xfs (which we recommend in the handbook) and btrfs. Also some README.gentoo

Re: [gentoo-dev] [PATCH 1/4] readme.gentoo-r1.eclass: display readme if content changed (or fresh install)

2024-06-04 Thread Ulrich Mueller
> On Tue, 04 Jun 2024, Florian Schmaus wrote: > Both is fine with me. > That said, many filesystem support inline data. If I am not mistaken, > then its even enabled by default for xfs (which we recommend in the > handbook) and btrfs. Also some README.gentoo files become suitable for > inlini

Re: [gentoo-dev] [PATCH 1/4] readme.gentoo-r1.eclass: display readme if content changed (or fresh install)

2024-06-04 Thread Florian Schmaus
On 02/06/2024 20.24, Ulrich Mueller wrote: Installing another file just for the sake of avoiding "docompress -x" doesn't solve the problem but makes it worse, IMHO. Rather don't compress README.gentoo then. Both is fine with me. That said, many filesystem support inline data. If I am not mista

Re: [gentoo-dev] [PATCH 1/4] readme.gentoo-r1.eclass: display readme if content changed (or fresh install)

2024-06-02 Thread Ulrich Mueller
> On Sun, 02 Jun 2024, Eli Schwartz wrote: > readme.gentoo-r1.eclass as proposed in this thread is exactly such an > upstream program (gentoo is the upstream, and gentoo cannot cope with > compressed files there). > It strikes me as rules lawyering to use this as an argument against > the ecl

Re: [gentoo-dev] [PATCH 1/4] readme.gentoo-r1.eclass: display readme if content changed (or fresh install)

2024-06-02 Thread Eli Schwartz
On 6/2/24 12:28 PM, Ulrich Mueller wrote: >> On Sun, 02 Jun 2024, Eli Schwartz wrote: > >> Per the commit message, the old readme and the new readme can have the >> same contents, but be compressed by different compressors on the live >> system vs the image, and/or a compressor with unstable a

Re: [gentoo-dev] [PATCH 1/4] readme.gentoo-r1.eclass: display readme if content changed (or fresh install)

2024-06-02 Thread Florian Schmaus
On 02/06/2024 18.28, Ulrich Mueller wrote: On Sun, 02 Jun 2024, Eli Schwartz wrote: Per the commit message, the old readme and the new readme can have the same contents, but be compressed by different compressors on the live system vs the image, and/or a compressor with unstable algorithms, an

Re: [gentoo-dev] [PATCH 1/4] readme.gentoo-r1.eclass: display readme if content changed (or fresh install)

2024-06-02 Thread Ulrich Mueller
> On Sun, 02 Jun 2024, Eli Schwartz wrote: > Per the commit message, the old readme and the new readme can have the > same contents, but be compressed by different compressors on the live > system vs the image, and/or a compressor with unstable algorithms, > and/or one that isn't installed at

Re: [gentoo-dev] [PATCH 1/4] readme.gentoo-r1.eclass: display readme if content changed (or fresh install)

2024-06-02 Thread Florian Schmaus
On 02/06/2024 17.34, Ulrich Mueller wrote: On Sun, 02 Jun 2024, Florian Schmaus wrote: + ( + insinto "${_GREADME_DOC_DIR}" + + doins "${_GREADME_TMP_FILE}" + cksum --raw "${_GREADME_TMP_FILE}" | newins - "${_GREADME_HASH_FILENAME}" +

Re: [gentoo-dev] [PATCH 1/4] readme.gentoo-r1.eclass: display readme if content changed (or fresh install)

2024-06-02 Thread Eli Schwartz
On 6/2/24 11:34 AM, Ulrich Mueller wrote: >> On Sun, 02 Jun 2024, Florian Schmaus wrote: > >> +( >> +insinto "${_GREADME_DOC_DIR}" >> + >> +doins "${_GREADME_TMP_FILE}" >> +cksum --raw "${_GREADME_TMP_FILE}" | newins - >> "${_GREADME_HASH_FILENAME}" >>

Re: [gentoo-dev] [PATCH 1/4] readme.gentoo-r1.eclass: display readme if content changed (or fresh install)

2024-06-02 Thread Ulrich Mueller
> On Sun, 02 Jun 2024, Florian Schmaus wrote: > + ( > + insinto "${_GREADME_DOC_DIR}" > + > + doins "${_GREADME_TMP_FILE}" > + cksum --raw "${_GREADME_TMP_FILE}" | newins - > "${_GREADME_HASH_FILENAME}" > + assert > + ) Why do you need

[gentoo-dev] [PATCH 1/4] readme.gentoo-r1.eclass: display readme if content changed (or fresh install)

2024-06-02 Thread Florian Schmaus
Improve the user experience of readme.gentoo-r1.eclass by reducing the number of messages presented to the user upon emerge. We reduce the number of messages by only showing the contents of README.gentoo *if they have changed* (or on fresh installations). To be able to detect if the content has ch