Re: [gentoo-dev] [PATCH v5] go-module.eclass: deprecate EGO_SUM

2022-03-10 Thread William Hubbs
On Mon, Mar 07, 2022 at 01:10:46PM +0100, tastytea wrote: > On 2022-03-05 16:17-0600 William Hubbs wrote: > > > +# @CODE > > +# > > +# $ cd /path/to/project > > +# $ GOMODCACHE="${PWD}"/go-mod go mod download -modcacherw > > +# $ tar -acf project-1.0-deps.tar.xz go-mod > > What's the reason to u

Re: [gentoo-dev] [PATCH v5] go-module.eclass: deprecate EGO_SUM

2022-03-07 Thread tastytea
On 2022-03-05 16:17-0600 William Hubbs wrote: > +# @CODE > +# > +# $ cd /path/to/project > +# $ GOMODCACHE="${PWD}"/go-mod go mod download -modcacherw > +# $ tar -acf project-1.0-deps.tar.xz go-mod What's the reason to use `go mod download` here and not `go mod vendor`? The former seems to alway

Re: [gentoo-dev] [PATCH v5] go-module.eclass: deprecate EGO_SUM

2022-03-06 Thread William Hubbs
On Sun, Mar 06, 2022 at 09:20:03AM +, Sam James wrote: > > > > On 5 Mar 2022, at 22:17, William Hubbs wrote: > > > >EGO_SUM can be thousands of lines long in ebuilds, and it leads to > >creating Manifest files that are thousands of lines long. > >It has been determined that depe

Re: [gentoo-dev] [PATCH v5] go-module.eclass: deprecate EGO_SUM

2022-03-06 Thread Sam James
> On 5 Mar 2022, at 22:17, William Hubbs wrote: > >EGO_SUM can be thousands of lines long in ebuilds, and it leads to >creating Manifest files that are thousands of lines long. >It has been determined that dependency tarballs are a better solution if >upstream doesn't vendor the

[gentoo-dev] [PATCH v5] go-module.eclass: deprecate EGO_SUM

2022-03-05 Thread William Hubbs
EGO_SUM can be thousands of lines long in ebuilds, and it leads to creating Manifest files that are thousands of lines long. It has been determined that dependency tarballs are a better solution if upstream doesn't vendor their dependencies. Signed-off-by: William Hubbs --- e