Re: [gentoo-dev] [RFC] obs eclasses

2011-09-20 Thread Tomáš Chvátal
2011/9/20 Michał Górny : > On Tue, 13 Sep 2011 13:11:28 +0200 > Michal Hrusecky wrote: > >> please take a look at attached eclasses. Purpose is to make >> installation of obs services (plugins for osc) easier. >> >> Comments and improvements are welcome. > > I don't get the concept of having two e

Re: [gentoo-dev] [RFC] obs eclasses

2011-09-20 Thread Michał Górny
On Tue, 13 Sep 2011 13:11:28 +0200 Michal Hrusecky wrote: > please take a look at attached eclasses. Purpose is to make > installation of obs services (plugins for osc) easier. > > Comments and improvements are welcome. I don't get the concept of having two eclasses for this. The first one look

Re: [gentoo-dev] [RFC] obs eclasses

2011-09-15 Thread Michal Hrusecky
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Marijn - 9:35 15.09.11 wrote: > Hi Michal, > > On 09/14/11 10:56, Michal Hrusecky wrote: > > Hi, > > > > new versions of eclasses after hopefully fixing most of the > > comments. > > > > The download eclass speaks about ``openSUSE Build Service'

Re: [gentoo-dev] [RFC] obs eclasses

2011-09-15 Thread Marijn
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Michal, On 09/14/11 10:56, Michal Hrusecky wrote: > Hi, > > new versions of eclasses after hopefully fixing most of the > comments. > The download eclass speaks about ``openSUSE Build Service'' while the other calls it the ``Open Build Service''

Re: [gentoo-dev] [RFC] obs eclasses

2011-09-14 Thread Michal Hrusecky
Ulrich Mueller - 11:56 14.09.11 wrote: > > On Wed, 14 Sep 2011, Michal Hrusecky wrote: > > new versions of eclasses after hopefully fixing most of the comments. > > > # @ECLASS-VARIABLE: OPENSUSE_RELEASE > > # @ECLASS-VARIABLE: OBS_PROJECT > > # @ECLASS-VARIABLE: OPENSUSE_PACKAGE > > Can't th

Re: [gentoo-dev] [RFC] obs eclasses

2011-09-14 Thread Ulrich Mueller
> On Wed, 14 Sep 2011, Michal Hrusecky wrote: > new versions of eclasses after hopefully fixing most of the comments. > # @ECLASS-VARIABLE: OPENSUSE_RELEASE > # @ECLASS-VARIABLE: OBS_PROJECT > # @ECLASS-VARIABLE: OPENSUSE_PACKAGE Can't this use a single namespace, i.e. either "OBS" or "OPENSU

Re: [gentoo-dev] [RFC] obs eclasses

2011-09-14 Thread Michal Hrusecky
Hi, new versions of eclasses after hopefully fixing most of the comments. -- Michal Hrusecky # Copyright 1999-2011 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 # $Header: $ # @ECLASS: obs-download.eclass # @MAINTAINER: # mi...@gentoo.org # @BLURB

Re: [gentoo-dev] [RFC] obs eclasses

2011-09-14 Thread Michal Hrusecky
Donnie Berkholz - 9:59 13.09.11 wrote: > On 13:11 Tue 13 Sep , Michal Hrusecky wrote: > > # Copyright 1999-2011 Gentoo Foundation > > # Distributed under the terms of the GNU General Public License v2 > > # $Header: $ > > > > # @ECLASS: obs-download.eclass > > Are there going to be lots of p

Re: [gentoo-dev] [RFC] obs eclasses

2011-09-13 Thread Ciaran McCreesh
On Tue, 13 Sep 2011 11:41:00 -0500 Donnie Berkholz wrote: > Thanks for the reminder; I looked, and it turns out that we now have > a great precedent. Quoting PMS: > > "The required bash version was retroactively updated from 3.0 to 3.2 > in November 2009 (see http://www.gentoo. > org/proj/en/cou

Re: [gentoo-dev] [RFC] obs eclasses

2011-09-13 Thread Ciaran McCreesh
On Tue, 13 Sep 2011 17:58:15 +0200 Patrick Lauer wrote: > > It's because people want to pretend that it's possible for > > incredibly outdated systems (those with bash-3 only) to be updated. > > Actually it's worse - PMS enforces this, and the only clean way out is > to patch/fix/extend PMS to al

Re: [gentoo-dev] [RFC] obs eclasses

2011-09-13 Thread Michał Górny
On Tue, 13 Sep 2011 20:40:12 +0200 Ulrich Mueller wrote: > > On Tue, 13 Sep 2011, Michał Górny wrote: > > > The current situation is that you can't even install bash-3.2 > > systemwide because of the number of packages [ebuilds/eclasses] > > requiring on bash-4. > > Have you filed bug repor

Re: [gentoo-dev] [RFC] obs eclasses

2011-09-13 Thread Ulrich Mueller
> On Tue, 13 Sep 2011, Michał Górny wrote: > The current situation is that you can't even install bash-3.2 > systemwide because of the number of packages [ebuilds/eclasses] > requiring on bash-4. Have you filed bug reports for these? Ulrich

Re: [gentoo-dev] [RFC] obs eclasses

2011-09-13 Thread Michał Górny
On Tue, 13 Sep 2011 19:25:59 +0200 Ulrich Mueller wrote: > > On Tue, 13 Sep 2011, Donnie Berkholz wrote: > > > Thanks for the reminder; I looked, and it turns out that we now have > > a great precedent. > > > Quoting PMS: > > > "The required bash version was retroactively updated from 3.0

Re: [gentoo-dev] [RFC] obs eclasses

2011-09-13 Thread Amadeusz Żołnowski
Excerpts from Ulrich Mueller's message of 2011-09-13 19:25:59 +0200: > > On Tue, 13 Sep 2011, Donnie Berkholz wrote: > > > Thanks for the reminder; I looked, and it turns out that we now have > > a great precedent. > > > Quoting PMS: > > > "The required bash version was retroactively updated

Re: [gentoo-dev] [RFC] obs eclasses

2011-09-13 Thread Tomáš Chvátal
2011/9/13 Ulrich Mueller : >> On Tue, 13 Sep 2011, Donnie Berkholz wrote: > >> Thanks for the reminder; I looked, and it turns out that we now have >> a great precedent. > >> Quoting PMS: > >> "The required bash version was retroactively updated from 3.0 to 3.2 >> in November 2009 (see http://w

Re: [gentoo-dev] [RFC] obs eclasses

2011-09-13 Thread Ulrich Mueller
> On Tue, 13 Sep 2011, Donnie Berkholz wrote: > Thanks for the reminder; I looked, and it turns out that we now have > a great precedent. > Quoting PMS: > "The required bash version was retroactively updated from 3.0 to 3.2 > in November 2009 (see http://www.gentoo. > org/proj/en/council/mee

Re: [gentoo-dev] [RFC] obs eclasses

2011-09-13 Thread Donnie Berkholz
On 17:58 Tue 13 Sep , Patrick Lauer wrote: > On 09/13/11 16:44, Donnie Berkholz wrote: > > It's because people want to pretend that it's possible for > > incredibly outdated systems (those with bash-3 only) to be updated. > > Actually it's worse - PMS enforces this, and the only clean way out

Re: [gentoo-dev] [RFC] obs eclasses

2011-09-13 Thread Patrick Lauer
On 09/13/11 16:44, Donnie Berkholz wrote: > On 15:02 Tue 13 Sep , Amadeusz Żołnowski wrote: >> Excerpts from Joshua Kinard's message of 2011-09-13 14:26:02 +0200: You don't need -n/-z with [[. [[ $var ]] == [[ -n $var ]] [[ ! $var ]] == [[ -z $var ]] >>> >>> What about o

Re: [gentoo-dev] [RFC] obs eclasses

2011-09-13 Thread Nirbheek Chauhan
On Tue, Sep 13, 2011 at 8:29 PM, Donnie Berkholz wrote: >> HOMEPAGE="http://en.opensuse.org/openSUSE:OSC"; >> LICENSE="GPL-2" >> SLOT="0" >> IUSE="" >> RDEPEND+="dev-util/osc" > > You probably want a space here. > > RDEPEND+=" dev-util/osc" > Slightly bike-sheddy, but it's less error-prone to use

Re: [gentoo-dev] [RFC] obs eclasses

2011-09-13 Thread Donnie Berkholz
On 13:11 Tue 13 Sep , Michal Hrusecky wrote: > # Copyright 1999-2011 Gentoo Foundation > # Distributed under the terms of the GNU General Public License v2 > # $Header: $ > > # @ECLASS: obs-download.eclass Are there going to be lots of packages using this and not the other eclass? I wonder w

Re: [gentoo-dev] [RFC] obs eclasses

2011-09-13 Thread Donnie Berkholz
On 15:02 Tue 13 Sep , Amadeusz Żołnowski wrote: > Excerpts from Joshua Kinard's message of 2011-09-13 14:26:02 +0200: > > > You don't need -n/-z with [[. > > > > > > [[ $var ]] == [[ -n $var ]] > > > [[ ! $var ]] == [[ -z $var ]] > > > > What about other comparisons, like -f, -e, or -d? >

Re: [gentoo-dev] [RFC] obs eclasses

2011-09-13 Thread Michal Hrusecky
Amadeusz Żołnowski - 13:24 13.09.11 wrote: > Hi, > > > Excerpts from Michal Hrusecky's message of 2011-09-13 13:11:28 +0200: > > Comments and improvements are welcome. > > Just some minor remarks: > > > > [[ -z ${OPENSUSE_RELEASE} ]] || OBS_PROJECT="openSUSE:${OPENSUSE_RELEASE}" > > [[ -n ${OB

Re: [gentoo-dev] [RFC] obs eclasses

2011-09-13 Thread Michał Górny
On Tue, 13 Sep 2011 15:02:43 +0200 Amadeusz Żołnowski wrote: > OT: When I was going through recruitment process, dberkholz pointed to > me that I use things bash4-only. And again: why we need to stick to > ancient 3 version? I would understand pseudo POSIX compatibility, but > what is the benefit

Re: [gentoo-dev] [RFC] obs eclasses

2011-09-13 Thread Amadeusz Żołnowski
Excerpts from Joshua Kinard's message of 2011-09-13 14:26:02 +0200: > > You don't need -n/-z with [[. > > > > [[ $var ]] == [[ -n $var ]] > > [[ ! $var ]] == [[ -z $var ]] > > What about other comparisons, like -f, -e, or -d? Same as inside [, but no need of quotes inside [[. > Also, is thi

Re: [gentoo-dev] [RFC] obs eclasses

2011-09-13 Thread Joshua Kinard
On 09/13/2011 07:24, Amadeusz Żołnowski wrote: > Hi, > > > Excerpts from Michal Hrusecky's message of 2011-09-13 13:11:28 +0200: >> Comments and improvements are welcome. > > Just some minor remarks: > > >> [[ -z ${OPENSUSE_RELEASE} ]] || OBS_PROJECT="openSUSE:${OPENSUSE_RELEASE}" >> [[ -n ${

Re: [gentoo-dev] [RFC] obs eclasses

2011-09-13 Thread Amadeusz Żołnowski
Hi, Excerpts from Michal Hrusecky's message of 2011-09-13 13:11:28 +0200: > Comments and improvements are welcome. Just some minor remarks: > [[ -z ${OPENSUSE_RELEASE} ]] || OBS_PROJECT="openSUSE:${OPENSUSE_RELEASE}" > [[ -n ${OBS_PROJECT} ]] || die "OBS_PROJECT not set!" > [[ -n ${OBS_PA

[gentoo-dev] [RFC] obs eclasses

2011-09-13 Thread Michal Hrusecky
Hi, please take a look at attached eclasses. Purpose is to make installation of obs services (plugins for osc) easier. Comments and improvements are welcome. Regards -- Michal Hrusecky # Copyright 1999-2011 Gentoo Foundation # Distributed under the terms of the GNU General Public Lice