[gentoo-dev] [RFC] qt5-build.eclass

2014-08-17 Thread Davide Pesavento
Hi guys, In preparation for moving Qt5 to gentoo-x86 (finally!), please review the attached eclass that is inherited by every Qt5 ebuild. If you want to get an idea about how the ebuild code looks like, see any ebuild in the dev-qt category of our overlay that inherits the eclass: https://gi

Re: [gentoo-dev] [RFC] qt5-build.eclass

2014-08-17 Thread Maxim Koltsov
2014-08-17 22:38 GMT+04:00 Davide Pesavento : > Hi guys, > > In preparation for moving Qt5 to gentoo-x86 (finally!), please review > the attached eclass that is inherited by every Qt5 ebuild. > > If you want to get an idea about how the ebuild code looks like, see > any ebuild in the dev-qt catego

Re: [gentoo-dev] [RFC] qt5-build.eclass

2014-08-17 Thread Georg Rudoy
2014-08-17 22:56 GMT+04:00 Maxim Koltsov : > For the record: I /think/ that an eclass for packages supporting both qt4 > and qt5 (using multibuild.eclass) /might/ be useful. Looking forward to > hearing Qt team opinion. I second this opinion (especially after porting a few libraries' ebuilds to mu

Re: [gentoo-dev] [RFC] qt5-build.eclass

2014-08-17 Thread Davide Pesavento
On Sun, Aug 17, 2014 at 8:56 PM, Maxim Koltsov wrote: > > For the record: I /think/ that an eclass for packages supporting both qt4 > and qt5 (using multibuild.eclass) /might/ be useful. Looking forward to > hearing Qt team opinion. Maybe. But you'll have to convince me. We aren't planning on wri

Re: [gentoo-dev] [RFC] qt5-build.eclass

2014-08-20 Thread Michał Górny
Dnia 2014-08-17, o godz. 20:38:18 Davide Pesavento napisał(a): > # @FUNCTION: qt5-build_src_unpack > # @DESCRIPTION: > # Unpacks the sources. > qt5-build_src_unpack() { > if [[ $(gcc-major-version) -lt 4 ]] || [[ $(gcc-major-version) -eq 4 && > $(gcc-minor-version) -lt 5 ]]; then >

Re: [gentoo-dev] [RFC] qt5-build.eclass

2014-08-20 Thread hasufell
Michał Górny: >> sed -i -e '/^CPPFLAGS\s*=/ s/-g //' \ >> qmake/Makefile.unix || die "sed failed (CPPFLAGS for >> qmake build)" >> >> # Respect CXX in {bsymbolic_functions,fvisibility,precomp}.test >> sed -i -e "/^QMAKE_CONF_COMPILER=/ s:

Re: [gentoo-dev] [RFC] qt5-build.eclass

2014-08-26 Thread Davide Pesavento
On Wed, Aug 20, 2014 at 10:07 AM, Michał Górny wrote: > Dnia 2014-08-17, o godz. 20:38:18 > Davide Pesavento napisał(a): > >> # @FUNCTION: qt5-build_src_unpack >> # @DESCRIPTION: >> # Unpacks the sources. >> qt5-build_src_unpack() { >> if [[ $(gcc-major-version) -lt 4 ]] || [[ $(gcc-major-v