Re: [gentoo-dev] Default src_install for EAPI-2 or following EAPI

2008-10-05 Thread Thomas Sachau
Robert Buchholz schrieb: > On Sunday, 5. October 2008, Ulrich Mueller wrote: >>> On Sun, 5 Oct 2008, Robert Buchholz wrote: > It's not. If you want to have default DOCS then you should loop > through the items and check with [[ -e ]] before trying to > install them. So, maybe j

Re: [gentoo-dev] Default src_install for EAPI-2 or following EAPI

2008-10-05 Thread Ulrich Mueller
> On Sun, 5 Oct 2008, Robert Buchholz wrote: >> So if the ebuild includes non-existing files in DOCS, then why would >> you want to suppress the warnings? > I don't. My point was that the default action on an empty DOCS > variable is to "dodoc AUTHORS ChangeLog NEWS README", and this > should

Re: [gentoo-dev] Default src_install for EAPI-2 or following EAPI

2008-10-05 Thread Robert Buchholz
On Sunday, 5. October 2008, Ulrich Mueller wrote: > > On Sun, 5 Oct 2008, Robert Buchholz wrote: > >> > > >> > It's not. If you want to have default DOCS then you should loop > >> > through the items and check with [[ -e ]] before trying to > >> > install them. > >> > >> So, maybe just do a 'do

Re: [gentoo-dev] Default src_install for EAPI-2 or following EAPI

2008-10-05 Thread Ulrich Mueller
> On Sun, 5 Oct 2008, Robert Buchholz wrote: >> > It's not. If you want to have default DOCS then you should loop >> > through the items and check with [[ -e ]] before trying to >> > install them. >> So, maybe just do a 'dodoc "${DOCS}"' and omit the die? Then it won't >> fail but the warning

Re: [gentoo-dev] Default src_install for EAPI-2 or following EAPI

2008-10-05 Thread Robert Buchholz
On Sunday, 5. October 2008, Ulrich Mueller wrote: > > On Tue, 30 Sep 2008, Petteri Räty wrote: > >>> > >>> dodoc ${DOCS} || die "dodoc failed" > >> > >> This seems alright fine to me > > > > It's not. If you want to have default DOCS then you should loop > > through the items and check with [[

Re: [gentoo-dev] Default src_install for EAPI-2 or following EAPI

2008-10-05 Thread Ulrich Mueller
> On Tue, 30 Sep 2008, Petteri Räty wrote: >>> dodoc ${DOCS} || die "dodoc failed" >> This seems alright fine to me > It's not. If you want to have default DOCS then you should loop > through the items and check with [[ -e ]] before trying to install > them. I'm not convinced that this is a

Re: [gentoo-dev] Default src_install for EAPI-2 or following EAPI

2008-09-21 Thread Fabian Groffen
On 21-09-2008 02:47:41 +0200, Thomas Sachau wrote: > updated version: > if [ -f Makefile -o -f GNUmakefile -o -f makefile ]; then > emake DESTDIR="${D}" install || einstall > if [[ $?>0 ]]; then Please either use POSIX or bash, mixing them looks so ugly and point

Re: [gentoo-dev] Default src_install for EAPI-2 or following EAPI

2008-09-20 Thread Thomas Sachau
Petteri Räty schrieb: > Thomas Sachau kirjoitti: >> I see, we have a default src_unpack and a default src_compile but a >> default src_install is still >> missing. Here is my suggestion (taken and modified from bug 33544): >> >> src_install() { >> if [ -f Makefile -o -f GNUmakefile -o -f makefi

Re: [gentoo-dev] Default src_install for EAPI-2 or following EAPI

2008-09-20 Thread Petteri Räty
Thomas Sachau kirjoitti: I see, we have a default src_unpack and a default src_compile but a default src_install is still missing. Here is my suggestion (taken and modified from bug 33544): src_install() { if [ -f Makefile -o -f GNUmakefile -o -f makefile ]; then emake D

[gentoo-dev] Default src_install for EAPI-2 or following EAPI

2008-09-20 Thread Thomas Sachau
I see, we have a default src_unpack and a default src_compile but a default src_install is still missing. Here is my suggestion (taken and modified from bug 33544): src_install() { if [ -f Makefile -o -f GNUmakefile -o -f makefile ]; then emake DESTDIR=${D} install || die