Re: [gentoo-dev] Help testing ebuilds? golang/Fabio load balancer

2017-11-13 Thread Michael Orlitzky
On 11/12/2017 10:21 AM, Ulrich Mueller wrote: > >> * Change the PMS to remove "undefined behavior" and replace it with >> "empty directories must be tracked, and may only be removed once no >> installed package is using them," or something along those lines. >> That leaves the

Re: [gentoo-dev] Help testing ebuilds? golang/Fabio load balancer

2017-11-13 Thread Michael Orlitzky
On 11/12/2017 08:43 AM, Michał Górny wrote: > > I'm not convinced a QA warning is valid, given that not every empty > directory is meaningful. You're going to either cause people to create > unnecessary 'keepdir's, or to be swamped by false positives. The warning would essentially be saying,

Re: [gentoo-dev] Help testing ebuilds? golang/Fabio load balancer

2017-11-12 Thread Ulrich Mueller
> On Sun, 12 Nov 2017, Michael Orlitzky wrote: > Some day -- I'll add it to my list. For now I'll update the docs to > explain why you should use keepdir, and do a QA warning for empty > directories. Then how does this sound for EAPI=next? > * Ban keepdir. > * Have portage call its

Re: [gentoo-dev] Help testing ebuilds? golang/Fabio load balancer

2017-11-12 Thread Michał Górny
W dniu nie, 12.11.2017 o godzinie 07∶53 -0500, użytkownik Michael Orlitzky napisał: > On 11/11/2017 02:26 PM, Michał Górny wrote: > > > > > > As far as the actual implementation goes, I'm not sure that > > > automatically-generated ".keep" files are better than having the package > > > manager

Re: [gentoo-dev] Help testing ebuilds? golang/Fabio load balancer

2017-11-12 Thread Michael Orlitzky
On 11/11/2017 02:26 PM, Michał Górny wrote: >> >> As far as the actual implementation goes, I'm not sure that >> automatically-generated ".keep" files are better than having the package >> manager maintain its own database. The latter would be more complex, but >> would avoid littering everyone's

Re: [gentoo-dev] Help testing ebuilds? golang/Fabio load balancer

2017-11-11 Thread Brian Dolbec
On Sat, 11 Nov 2017 12:31:15 -0500 Michael Orlitzky wrote: > Essentially,we have two commands to create a directory, "dodir" and > "do-empty-dir" (which we call "keepdir"). The latter is only necessary > due to an implementation detail, so it doesn't belong in the user >

Re: [gentoo-dev] Help testing ebuilds? golang/Fabio load balancer

2017-11-11 Thread Michał Górny
W dniu sob, 11.11.2017 o godzinie 12∶31 -0500, użytkownik Michael Orlitzky napisał: > > > and a meta-question, > > > > > > c) Seriously, empty directories are undefined behavior? > > > > ...and how could they be defined if a directory can be installed by > > multiple packages and has no

Re: [gentoo-dev] Help testing ebuilds? golang/Fabio load balancer

2017-11-11 Thread Michael Orlitzky
On 11/11/2017 02:58 AM, Michał Górny wrote: >> >> Certainly "keepdir" will make the directory non-empty, but with the >> additional (unwanted) side-effect that the directory won't be removed >> when the package is uninstalled. > > Wrong. It creates a dotfile inside it, and removes it along with

Re: [gentoo-dev] Help testing ebuilds? golang/Fabio load balancer

2017-11-10 Thread Michał Górny
W dniu pią, 10.11.2017 o godzinie 19∶21 -0500, użytkownik Michael Orlitzky napisał: > On 11/10/2017 04:36 PM, Damo Brisbane wrote: > > > > Re for...keepdir, I found removing it then the /var/log/fabio folders > > were not getting created, so keeping it in there. > > You need to tell the ebuild

Re: [gentoo-dev] Help testing ebuilds? golang/Fabio load balancer

2017-11-10 Thread Michael Orlitzky
On 11/10/2017 04:36 PM, Damo Brisbane wrote: > > Re for...keepdir, I found removing it then the /var/log/fabio folders > were not getting created, so keeping it in there. You need to tell the ebuild to create that directory one way or another. The "dodir" function will create the directory, but

Re: [gentoo-dev] Help testing ebuilds? golang/Fabio load balancer

2017-11-10 Thread Damo Brisbane
Cheers Michael, I've made most those changes, including USER/GROUP*, that confuses me too; copied pattern from another ebuild. Also removed creating separate folder /etc/fabio.d; re this, I noticed the fabio configuration accepts either folder path or *URL* for configuration file; not sure how

Re: [gentoo-dev] Help testing ebuilds? golang/Fabio load balancer

2017-11-10 Thread Michael Orlitzky
On 11/09/2017 11:08 PM, Damo Brisbane wrote: > I've run up a couple of golang based ebuilds - for the fabio load > balancer. My first run at it, not completely sure of any follow up > process, mentor? other posting, overlap with existing work? Anyway, > would appreciate the feedback. Your

[gentoo-dev] Help testing ebuilds? golang/Fabio load balancer

2017-11-09 Thread Damo Brisbane
I've run up a couple of golang based ebuilds - for the fabio load balancer. My first run at it, not completely sure of any follow up process, mentor? other posting, overlap with existing work? Anyway, would appreciate the feedback. FYI, custom overlay at *