Re: [gentoo-dev] Quoting patch for repoman

2007-10-01 Thread Alec Warner
On 9/30/07, Alec Warner <[EMAIL PROTECTED]> wrote: > On 9/30/07, Mike Frysinger <[EMAIL PROTECTED]> wrote: > > On Sunday 30 September 2007, Zac Medico wrote: > > > Donnie Berkholz wrote: > > > > On 04:52 Sat 29 Sep , Mike Frysinger wrote: > > > >> does this work with multilines ? > > > >> if [[

Re: [gentoo-dev] Quoting patch for repoman

2007-09-30 Thread Alec Warner
On 9/30/07, Mike Frysinger <[EMAIL PROTECTED]> wrote: > On Sunday 30 September 2007, Zac Medico wrote: > > Donnie Berkholz wrote: > > > On 04:52 Sat 29 Sep , Mike Frysinger wrote: > > >> does this work with multilines ? > > >> if [[ -e ${S}/asdfasdfasdf && \ > > >>-f ${WORKDIR}/moo ]] > > >

Re: [gentoo-dev] Quoting patch for repoman

2007-09-30 Thread Mike Frysinger
On Sunday 30 September 2007, Zac Medico wrote: > Donnie Berkholz wrote: > > On 04:52 Sat 29 Sep , Mike Frysinger wrote: > >> does this work with multilines ? > >> if [[ -e ${S}/asdfasdfasdf && \ > >>-f ${WORKDIR}/moo ]] > >> then > >> > >> this is a crappy example, but entirely correct when

Re: [gentoo-dev] Quoting patch for repoman

2007-09-30 Thread Zac Medico
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Donnie Berkholz wrote: > On 04:52 Sat 29 Sep , Mike Frysinger wrote: >> does this work with multilines ? >> if [[ -e ${S}/asdfasdfasdf && \ >>-f ${WORKDIR}/moo ]] >> then >> >> this is a crappy example, but entirely correct when the if statemen

Re: [gentoo-dev] Quoting patch for repoman

2007-09-29 Thread Donnie Berkholz
On 04:52 Sat 29 Sep , Mike Frysinger wrote: > does this work with multilines ? > if [[ -e ${S}/asdfasdfasdf && \ >-f ${WORKDIR}/moo ]] > then > > this is a crappy example, but entirely correct when the if statement > gets real long ... No, it doesn't. That's why I just made it a warning

Re: [gentoo-dev] Quoting patch for repoman

2007-09-29 Thread Mike Frysinger
On Saturday 29 September 2007, Donnie Berkholz wrote: > On 01:09 Sat 29 Sep , Donnie Berkholz wrote: > > I put together a quick repoman patch to check for the quoting issues > > that've kept coming up in reviews lately. Give it a shot and fix it if > > you have problems. > > Woops, the last one

Re: [gentoo-dev] Quoting patch for repoman

2007-09-29 Thread Donnie Berkholz
On 01:33 Sat 29 Sep , Donnie Berkholz wrote: Take 3. Adds ROOT to variables checked. Thanks, Donnie --- repoman.orig2007-09-29 00:05:30.0 -0700 +++ repoman 2007-09-29 01:33:27.0 -0700 @@ -188,6 +188,7 @@ "ebuild.majorsyn":"This ebuild has a major syntax err

Re: [gentoo-dev] Quoting patch for repoman

2007-09-29 Thread Donnie Berkholz
On 01:09 Sat 29 Sep , Donnie Berkholz wrote: > I put together a quick repoman patch to check for the quoting issues > that've kept coming up in reviews lately. Give it a shot and fix it if > you have problems. > > Thanks, > Donnie Woops, the last one didn't exclude [[ ]] cases properly beca

[gentoo-dev] Quoting patch for repoman

2007-09-29 Thread Donnie Berkholz
I put together a quick repoman patch to check for the quoting issues that've kept coming up in reviews lately. Give it a shot and fix it if you have problems. Thanks, Donnie --- repoman.orig2007-09-29 00:05:30.0 -0700 +++ repoman 2007-09-29 01:06:09.0 -0700 @@ -188,6