[gentoo-dev] Re: [PATCH eutils] Introduce run_in_build_dir() used in a few ebuilds.

2013-01-14 Thread Duncan
Mike Frysinger posted on Mon, 14 Jan 2013 17:09:51 -0500 as excerpted: >>> + [[ ${BUILD_DIR} ]] || die "${FUNCNAME}: BUILD_DIR not set." >> >> really should use -n there > >> Doesn't matter. > > the point wasn't "will it work". it's more "how easy is it to glance at > code and know what it i

Re: [gentoo-dev] Re: [PATCH eutils] Introduce run_in_build_dir() used in a few ebuilds.

2013-01-14 Thread Dan Douglas
On Tuesday, January 15, 2013 03:20:20 AM Duncan wrote: > Mike Frysinger posted on Mon, 14 Jan 2013 17:09:51 -0500 as excerpted: > > >>> + [[ ${BUILD_DIR} ]] || die "${FUNCNAME}: BUILD_DIR not set." > >> > >> really should use -n there > > > >> Doesn't matter. > > > > the point wasn't "will it w

Re: [gentoo-dev] Re: [PATCH eutils] Introduce run_in_build_dir() used in a few ebuilds.

2013-01-15 Thread Mike Frysinger
On Monday 14 January 2013 22:20:20 Duncan wrote: > Mike Frysinger posted on Mon, 14 Jan 2013 17:09:51 -0500 as excerpted: > >>> + [[ ${BUILD_DIR} ]] || die "${FUNCNAME}: BUILD_DIR not set." > >> > >> really should use -n there > >> > >> Doesn't matter. > > > > the point wasn't "will it work". i