Re: [gentoo-dev] dont use `which` in ebuilds

2007-03-18 Thread Paul de Vrieze
On Friday 16 March 2007, Petteri Räty wrote: > Ned Ludd wrote: > > Here are the remaining offenders for sync 1174037821 that match > > '$(which ' or '`which ' in eclasses and ebuilds. > > > > dev-db/hsqldb/hsqldb-1.7.3.1-r1.ebuild:48: > > This one just echos which to a script so it's safe I think.

Re: [gentoo-dev] dont use `which` in ebuilds

2007-03-16 Thread Luca Longinotti
Ned Ludd wrote: > Here are the remaining offenders for sync 1174037821 that match > '$(which ' or '`which ' in eclasses and ebuilds. > > eclass/mysql.eclass:529: > eclass/mysql.eclass:530: > media-libs/pdflib/pdflib-5.0.4_p1-r1.ebuild:39: > media-libs/pdflib/pdflib-6.0.3-r1.ebuild:48: > media-lib

Re: [gentoo-dev] dont use `which` in ebuilds

2007-03-16 Thread Danny van Dyk
Am Freitag, 16. März 2007 23:16 schrieb Ned Ludd: > On Mon, 2007-03-12 at 19:15 -0400, Mike Frysinger wrote: > > On Monday 12 March 2007, Mike Frysinger wrote: > > Here are the remaining offenders for sync 1174037821 that match > '$(which ' or '`which ' in eclasses and ebuilds. > > sci-mathematics

Re: [gentoo-dev] dont use `which` in ebuilds

2007-03-16 Thread Petteri Räty
Ned Ludd wrote: > Here are the remaining offenders for sync 1174037821 that match > '$(which ' or '`which ' in eclasses and ebuilds. > dev-db/hsqldb/hsqldb-1.7.3.1-r1.ebuild:48: This one just echos which to a script so it's safe I think. Regards, Petteri signature.asc Description: OpenPGP d

Re: [gentoo-dev] dont use `which` in ebuilds

2007-03-16 Thread Ned Ludd
On Mon, 2007-03-12 at 19:15 -0400, Mike Frysinger wrote: > On Monday 12 March 2007, Mike Frysinger wrote: > > instead, since we require bash for our ebuilds, use the builtin `type -p` > > err i botched that ;) > > `type -p` is almost a complete drop in replacement for which ... it does not > wor

Re: [gentoo-dev] dont use `which` in ebuilds

2007-03-16 Thread Lars Weiler
* Ned Ludd <[EMAIL PROTECTED]> [07/03/12 16:36 -0700]: > app-cdr/cdrkit/cdrkit-1.0.ebuild:26: > app-cdr/cdrkit/cdrkit-1.1.2.ebuild:28: Those are fixed. Regards, Lars -- Lars Weiler <[EMAIL PROTECTED]> +49-171-1963258 Instant Messaging : [EMAIL PROTECTED] Gentoo Linux PowerPC : Strategica

Re: [gentoo-dev] dont use `which` in ebuilds

2007-03-13 Thread Mike Frysinger
On Tuesday 13 March 2007, Matthias Schwarzott wrote: > The scripts installed by these ebuilds also use which: > sys-kernel/module-rebuild: that's a different issue ... this is a Linux-only package, so it can "safely" depend on the behavior of the which app that is installed onto our Linux hosts

Re: [gentoo-dev] dont use `which` in ebuilds

2007-03-13 Thread Matthias Schwarzott
On Dienstag, 13. März 2007, Ned Ludd wrote: > On Mon, 2007-03-12 at 19:15 -0400, Mike Frysinger wrote: > > On Monday 12 March 2007, Mike Frysinger wrote: > > > instead, since we require bash for our ebuilds, use the builtin `type > > > -p` > > > > err i botched that ;) > > > > `type -p` is almost a

Re: [gentoo-dev] dont use `which` in ebuilds

2007-03-13 Thread Matthias Schwarzott
On Dienstag, 13. März 2007, Thomas de Grenier de Latour wrote: > ./eclass/vdr-plugin.eclass: >if which md5sum >/dev/null 2>&1; then ^^ fixed Matthias -- Matthias Schwarzott (zzam) -- gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] dont use `which` in ebuilds

2007-03-12 Thread Andrew Ross
Ned Ludd wrote: > On Mon, 2007-03-12 at 19:15 -0400, Mike Frysinger wrote: >> On Monday 12 March 2007, Mike Frysinger wrote: >>> instead, since we require bash for our ebuilds, use the builtin `type -p` >> `type -p` is almost a complete drop in replacement for which ... it does not >> work on bas

Re: [gentoo-dev] dont use `which` in ebuilds

2007-03-12 Thread Yuri Vasilevski
On Mon, 12 Mar 2007 16:36:03 -0700 Ned Ludd <[EMAIL PROTECTED]> wrote: > And matches "$(which " > x11-misc/xoo/xoo-0.7.ebuild:25: Fixed. Best wishes, Yuri. -- gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] dont use `which` in ebuilds

2007-03-12 Thread Chris Gianelloni
On Mon, 2007-03-12 at 16:36 -0700, Ned Ludd wrote: > games-emulation/advancemame/advancemame-0.104.0.ebuild:35: > games-emulation/advancemame/advancemame-0.104.0.ebuild:37: > games-emulation/advancemame/advancemame-0.104.0.ebuild:39: > games-emulation/advancemame/advancemame-0.106.0.ebuild:40: > ga

Re: [gentoo-dev] dont use `which` in ebuilds

2007-03-12 Thread Mike Kelly
On Tue, 13 Mar 2007 01:14:54 +0100 Thomas de Grenier de Latour <[EMAIL PROTECTED]> wrote: > Also there are some occurences in eclasses: > ./eclass/vim-doc.eclass: >vim=$(which vim 2>/dev/null) > ./eclass/vim-doc.eclass: >[[ -z "$vim" ]] && vim=$(which gvim 2>/dev/null) > ./eclass/vim-doc

Re: [gentoo-dev] dont use `which` in ebuilds

2007-03-12 Thread Danny van Dyk
Am Dienstag, 13. März 2007 01:14 schrieb Thomas de Grenier de Latour: > On 2007/03/12, Ned Ludd <[EMAIL PROTECTED]> wrote: > > Matches "`which " > > ... > > And matches "$(which " > > ... > > Also there are some occurences in eclasses: > ./eclass/fortran.eclass: >elif [ -x "$(which ifc 2> /dev

Re: [gentoo-dev] dont use `which` in ebuilds

2007-03-12 Thread Danny van Dyk
Am Dienstag, 13. März 2007 00:36 schrieb Ned Ludd: > > > instead, since we require bash for our ebuilds, use the builtin > > > `type -p` > > > > err i botched that ;) > > > > `type -p` is almost a complete drop in replacement for which ... it > > does not work on bash builtins however, so people sh

Re: [gentoo-dev] dont use `which` in ebuilds

2007-03-12 Thread Thomas de Grenier de Latour
On 2007/03/12, Ned Ludd <[EMAIL PROTECTED]> wrote: > Matches "`which " > ... > And matches "$(which " > ... Also there are some occurences in eclasses: ./eclass/enlightenment.eclass: cp $(which gettextize) "${T}"/ || die "could not copy gettextize" ./eclass/fortran.eclass: elif [ -x "$(w

Re: [gentoo-dev] dont use `which` in ebuilds

2007-03-12 Thread Ned Ludd
On Mon, 2007-03-12 at 19:15 -0400, Mike Frysinger wrote: > On Monday 12 March 2007, Mike Frysinger wrote: > > instead, since we require bash for our ebuilds, use the builtin `type -p` > > err i botched that ;) > > `type -p` is almost a complete drop in replacement for which ... it does not > wor

Re: [gentoo-dev] dont use `which` in ebuilds

2007-03-12 Thread Mike Frysinger
On Monday 12 March 2007, Mike Frysinger wrote: > instead, since we require bash for our ebuilds, use the builtin `type -p` err i botched that ;) `type -p` is almost a complete drop in replacement for which ... it does not work on bash builtins however, so people should use `type -P` to force the

[gentoo-dev] dont use `which` in ebuilds

2007-03-12 Thread Mike Frysinger
please dont use the `which` program in your ebuilds ... this thing isnt even close to having standard behavior out there plus people can unmerge it :) instead, since we require bash for our ebuilds, use the builtin `type -p` ... here's some easy examples: -if which foo 2>/dev/null ; then +if ty