Re: [gentoo-dev] git-r3: initial draft for review

2013-09-10 Thread Michał Górny
Dnia 2013-09-10, o godz. 07:04:49 Peter Stuge pe...@stuge.se napisał(a): Markos Chandras wrote: the whole eclass is inside the if [[ ! ${_GIT_R3} ]] block. Rather than putting the whole eclass inside a block like that maybe it's possible to test for that condition and exit early? Could

Re: [gentoo-dev] git-r3: initial draft for review

2013-09-10 Thread Peter Stuge
Michał Górny wrote: the whole eclass is inside the if [[ ! ${_GIT_R3} ]] block. Rather than putting the whole eclass inside a block like that maybe it's possible to test for that condition and exit early? exiting ebuild process in middle of inheritance chain is *not* a good idea I

Re: [gentoo-dev] git-r3: initial draft for review

2013-09-09 Thread Peter Stuge
Markos Chandras wrote: the whole eclass is inside the if [[ ! ${_GIT_R3} ]] block. Rather than putting the whole eclass inside a block like that maybe it's possible to test for that condition and exit early? //Peter

Re: [gentoo-dev] git-r3: initial draft for review [v2]

2013-09-03 Thread Walter Dnes
On Mon, Sep 02, 2013 at 01:33:19PM +0200, Micha?? Górny wrote Dnia 2013-09-01, o godz. 16:49:34 William Hubbs willi...@gentoo.org napisa??(a): Please don't. I also do not want escape sequences in log files. Ok, '--color' removed. However, I think we should work something out to get both

Re: [gentoo-dev] git-r3: initial draft for review [v2]

2013-09-02 Thread Michał Górny
Dnia 2013-09-01, o godz. 16:49:34 William Hubbs willi...@gentoo.org napisał(a): On Sat, Aug 31, 2013 at 10:48:32PM +0200, Michał Górny wrote: Dnia 2013-08-31, o godz. 11:26:30 Ulrich Mueller u...@gentoo.org napisał(a): On Sat, 31 Aug 2013, Michał Górny wrote: And time for a

Re: [gentoo-dev] git-r3: initial draft for review [v2]

2013-09-01 Thread William Hubbs
On Sat, Aug 31, 2013 at 10:48:32PM +0200, Michał Górny wrote: Dnia 2013-08-31, o godz. 11:26:30 Ulrich Mueller u...@gentoo.org napisał(a): On Sat, 31 Aug 2013, Michał Górny wrote: And time for a small update. In git-r3_checkout: git --no-pager diff --color

Re: [gentoo-dev] git-r3: initial draft for review

2013-08-31 Thread Michał Górny
Dnia 2013-08-31, o godz. 01:17:26 Markos Chandras hwoar...@gentoo.org napisał(a): On 31 August 2013 00:37, Michał Górny mgo...@gentoo.org wrote: Hello, all. After a few days of thinking, discovering and working, here it is. The first working draft of new git eclass codenamed 'git-r3'.

Re: [gentoo-dev] git-r3: initial draft for review

2013-08-31 Thread Michał Górny
Dnia 2013-08-31, o godz. 06:55:01 C. Bergström cbergst...@pathscale.com napisał(a): Do you have any plans to add support for sparse checkout? Something like this |cd parentdir git clone -n url cd repo_dir git remote add –f name url git config core.sparsecheckout true echo /foldername/

Re: [gentoo-dev] git-r3: initial draft for review

2013-08-31 Thread Michał Górny
Dnia 2013-08-31, o godz. 01:46:40 Rick \Zero_Chaos\ Farina zeroch...@gentoo.org napisał(a): 5. Safer default EGIT_DIR choice. EGIT_PROJECT removed. Since submodules are cloned as separate repositories as well, we can't afford having EGIT_PROJECT to change the clone dir. Instead, the

Re: [gentoo-dev] git-r3: initial draft for review [v2]

2013-08-31 Thread Michał Górny
And time for a small update. Dnia 2013-08-31, o godz. 01:37:44 Michał Górny mgo...@gentoo.org napisał(a): 3. sys-fs/bedup's btrfs-progs submodule says the given commit id is 'not a valid branch point'. Need to investigate what this means. 4. 'git fetch --depth 1' seems to be refetching

Re: [gentoo-dev] git-r3: initial draft for review [v2]

2013-08-31 Thread Ulrich Mueller
On Sat, 31 Aug 2013, Michał Górny wrote: And time for a small update. In git-r3_checkout: git --no-pager diff --color --stat \ ${old_commit_id}..${new_commit_id} I'd rather omit the --color option, otherwise log files will contain escape sequences. Also it won't

Re: [gentoo-dev] git-r3: initial draft for review [v2]

2013-08-31 Thread Michał Górny
Dnia 2013-08-31, o godz. 11:26:30 Ulrich Mueller u...@gentoo.org napisał(a): On Sat, 31 Aug 2013, Michał Górny wrote: And time for a small update. In git-r3_checkout: git --no-pager diff --color --stat \ ${old_commit_id}..${new_commit_id} I'd rather

Re: [gentoo-dev] git-r3: initial draft for review [v3]

2013-08-31 Thread Michał Górny
A few more changes. 1. Added EGIT_CHECKOUT_DIR to control the place where stuff is checked out. 2. Moved the defaults from src_fetch() and src_unpack() into git-r3_fetch() and git-r3_checkout(). This makes using them easier, like: git-r3_fetch http://repo1 git-r3_fetch

[gentoo-dev] git-r3: initial draft for review

2013-08-30 Thread Michał Górny
Hello, all. After a few days of thinking, discovering and working, here it is. The first working draft of new git eclass codenamed 'git-r3'. First of all, the name is not final. I'm open to ideas. I'm open to naming it 'git-r1' to put it in line with my other -r1 eclasses :). I'd definitely like

Re: [gentoo-dev] git-r3: initial draft for review

2013-08-30 Thread C. Bergström
Do you have any plans to add support for sparse checkout? Something like this |cd parentdir git clone -n url cd repo_dir git remote add –f name url git config core.sparsecheckout true echo /foldername/ .git/info/sparse-checkout git checkout tagname (Credit goes to :

Re: [gentoo-dev] git-r3: initial draft for review

2013-08-30 Thread Markos Chandras
On 31 August 2013 00:37, Michał Górny mgo...@gentoo.org wrote: Hello, all. After a few days of thinking, discovering and working, here it is. The first working draft of new git eclass codenamed 'git-r3'. First of all, the name is not final. I'm open to ideas. I'm open to naming it 'git-r1'

Re: [gentoo-dev] git-r3: initial draft for review

2013-08-30 Thread Rick Zero_Chaos Farina
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/30/2013 07:37 PM, Michał Górny wrote: Hello, all. After a few days of thinking, discovering and working, here it is. The first working draft of new git eclass codenamed 'git-r3'. First of all, the name is not final. I'm open to ideas.