[gentoo-portage-dev] [PATCH] eapply_user: Make idempotent per changes to EAPI 6

2015-11-11 Thread Michał Górny
--- bin/phase-helpers.sh | 4 1 file changed, 4 insertions(+) diff --git a/bin/phase-helpers.sh b/bin/phase-helpers.sh index 2fea0b2..511a41a 100644 --- a/bin/phase-helpers.sh +++ b/bin/phase-helpers.sh @@ -1070,6 +1070,10 @@ fi if ___eapi_has_eapply_user; then eapply_user() { +

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2015-11-11 Thread Michał Górny
On Tue, 10 Nov 2015 18:53:03 -0500 Mike Frysinger wrote: > On 31 Oct 2015 09:08, Michał Górny wrote: > > On Sat, 31 Oct 2015 03:06:21 -0400 Mike Frysinger wrote: > > > On 30 Oct 2015 18:20, Michał Górny wrote: > > > > On Fri, 30 Oct 2015 12:03:59 + (UTC) "Justin

Re: [gentoo-dev] [PATCHES] python-utils-r1.eclass: Getter cleanup & ABIFLAGS preparation

2015-11-11 Thread Michał Górny
On Sun, 8 Nov 2015 10:35:04 +0100 Michał Górny wrote: > Hello, everyone. > > As you probably don't know, Justin lately noticed that we're carrying > some ugly hacks in Python 3.2+ where we diverge from upstream and break > binary compatibility for the sake of 'aesthetics'.

[gentoo-dev] [gentoo-dev-announce] Last rites:

2015-11-11 Thread Justin (jlec)
# Justin Lecher (28 Feb 2015) # Unfixed security problems # No upstream support anymore # CVE-2015-{0219,0220,0221,0222,5145} # #536586 # #554864 =dev-python/django-1.4* =dev-python/django-1.5* =dev-python/django-1.6* # Not supported by any django version upstream supports

Re: [gentoo-dev] [RFC] ban use of base-4 casemods in ebuilds due to locale collation instability

2015-11-11 Thread Michał Górny
On Wed, 11 Nov 2015 07:16:42 +0100 Patrick Lauer wrote: > On 11/11/2015 03:51 AM, Mike Frysinger wrote: > > On 10 Nov 2015 18:53, Mike Frysinger wrote: > >> i randomly stumbled across an ebuild that was using ^^ to make a variable > >> uppercase. this is new to bash-4.0

Re: [gentoo-dev] [RFC] ban use of base-4 casemods in ebuilds due to locale collation instability

2015-11-11 Thread Ciaran McCreesh
On Wed, 11 Nov 2015 07:16:42 +0100 Patrick Lauer wrote: > Wouldn't it be 'easier' (fsov easy) to have portage use sane-default > locale settings, so that estonian or turkish users don't get hit by > weirdness in the [a-z] character class etc.? Paludis forces all the LC

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-11 Thread Mike Frysinger
On 11 Nov 2015 10:32, Michał Górny wrote: > I'm not convinced we ought to do this for EAPI < 6. It is a breaking > change after all, and as such changes the behavior of EAPI < 6 ebuilds. that is a false statement. anything not working with bash-3.2 is already broken according to the PMS. >

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-11 Thread Mike Frysinger
On 11 Nov 2015 07:33, Ulrich Mueller wrote: > > On Tue, 10 Nov 2015, Mike Frysinger wrote: > > + # Set the compat level in case things change with newer ones. We must > > not > > + # export this into the env otherwise we might break other shell > > scripts we > > + # execute (e.g.

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

2015-11-11 Thread Luca Barbato
On 11/11/15 10:09, Michał Górny wrote: > I'd rather use the old standard 80. Minus 8 characters for friendly > e-mail quoting, which is also kinda 'old standard'. You can suggest as above, with this tone, and probably you would get some consensus. Personally I think 80col is nice since you can

[gentoo-dev] Revise EAPI 6? (was: [RFC] ban use of base-4 casemods in ebuilds due to locale collation instability)

2015-11-11 Thread Ulrich Mueller
> On Wed, 11 Nov 2015, Ciaran McCreesh wrote: > On Wed, 11 Nov 2015 07:16:42 +0100 > Patrick Lauer wrote: >> Wouldn't it be 'easier' (fsov easy) to have portage use sane-default >> locale settings, so that estonian or turkish users don't get hit by >> weirdness in the

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-11 Thread Michał Górny
On Tue, 10 Nov 2015 23:39:29 -0500 Mike Frysinger wrote: > To try and provide better stability across bash versions, > set the language compat level based on the current EAPI. > --- > bin/eapi.sh | 8 > bin/ebuild.sh | 39 +++ >

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-11 Thread Ulrich Mueller
> On Wed, 11 Nov 2015, Michał Górny wrote: > I'm not convinced we ought to do this for EAPI < 6. It is a breaking > change after all, and as such changes the behavior of EAPI < 6 > ebuilds. Which according to PMS should assume bash version 3.2. Also, AFAICS the only feature where the compat

[gentoo-dev] Executable location changes

2015-11-11 Thread Michael Orlitzky
We just got a bug, https://bugs.gentoo.org/show_bug.cgi?id=565500 due to the `uptime` binary changing locations in sys-process/procps-3.3.11-r2. The nagios-plugins package picks up the location of `uptime` while it's installing, so when users upgrade procps, some plugins stop working. Is

Re: [gentoo-dev] Executable location changes

2015-11-11 Thread Ulrich Mueller
> On Wed, 11 Nov 2015, Michael Orlitzky wrote: > We just got a bug, > https://bugs.gentoo.org/show_bug.cgi?id=565500 > due to the `uptime` binary changing locations in > sys-process/procps-3.3.11-r2. The nagios-plugins package picks up > the location of `uptime` while it's installing, so

Re: [gentoo-dev] Revise EAPI 6?

2015-11-11 Thread Mike Gilbert
On Wed, Nov 11, 2015 at 6:18 PM, Ulrich Mueller wrote: >> On Wed, 11 Nov 2015, Matthias Maier wrote: > >> On Wed, Nov 11, 2015, at 15:52 CST, "Jason A. Donenfeld" >> wrote: > >>> I'd be in favor of full-on LC_ALL=C. > >> ++ > >> I'm surprised that we do

Re: [gentoo-portage-dev] [PATCH] egencache: parallelize --update-changelogs (bug 565540)

2015-11-11 Thread Robin H. Johnson
Confirmed to work; please merge (also my prior patch that fixes relative GIT_DIR implications, or ACK and I will merge it myself). Speedup is less than expected however. Running with: --jobs 10 --load-average 6 yields a ~3.3x speedup on the previous non-parallel version. With the system load

Re: [gentoo-dev] Revise EAPI 6?

2015-11-11 Thread Ulrich Mueller
> On Wed, 11 Nov 2015, Mike Gilbert wrote: > On Wed, Nov 11, 2015 at 6:18 PM, Ulrich Mueller wrote: >> In the meantime, we could go with the minimum changes necessary to >> unbreak the bash 4.2 case conversion operators. Setting LC_COLLATE >> to C and LC_CTYPE to some sane

[gentoo-dev] Re: ChangeLog - Infra Response; update 2015/11/11, potential impact to 30min rsync cycle

2015-11-11 Thread Duncan
Robin H. Johnson posted on Wed, 11 Nov 2015 23:11:48 + as excerpted: > On Thu, Nov 05, 2015 at 12:54:06PM +0100, Alexis Ballier wrote: >> It's not perfectly clean but I don't see any problem here: >> ChangeLog-2015 : all ChangeLog from CVS ChangeLog: autogenerated from >> git > FYI, this was

Re: [gentoo-portage-dev] [PATCH] egencache: fix results when GIT_DIR is used in the environment.

2015-11-11 Thread Zac Medico
On 11/11/2015 02:30 PM, robb...@gentoo.org wrote: > From: "Robin H. Johnson" > > If GIT_DIR is used, and .git is outside the root of the checkout, then > --work-tree=... needs to be specified, otherwise any Git command that > relies on relative directories to the root will be

Re: [gentoo-portage-dev] [PATCH v2] ebuild: set up bash compat levels

2015-11-11 Thread Zac Medico
On 11/11/2015 01:00 PM, Mike Frysinger wrote: > To try and provide better stability across bash versions, > set the language compat level based on the current EAPI. > This does not ban newer features, it tells bash to use > the older bash behavior when the behavior changes across > versions. > ---

Re: [gentoo-dev] [gentoo-dev-announce] Last rites:

2015-11-11 Thread Hans de Graaff
On Wed, 2015-11-11 at 11:28 +0100, Justin (jlec) wrote: > # Justin Lecher (28 Feb 2015) > # Unfixed security problems > # No upstream support anymore > # CVE-2015-{0219,0220,0221,0222,5145} > # #536586 > # #554864 > =dev-python/django-1.4* > =dev-python/django-1.5* >

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-11 Thread Zac Medico
On 11/11/2015 01:11 PM, Mike Frysinger wrote: > On 11 Nov 2015 13:04, Zac Medico wrote: >> On 11/11/2015 12:55 PM, Mike Frysinger wrote: >>> On 11 Nov 2015 11:42, Zac Medico wrote: On 11/10/2015 08:39 PM, Mike Frysinger wrote: > +# Set up the bash version compatibility level. >

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-11 Thread Zac Medico
On 11/11/2015 10:33 PM, Zac Medico wrote: > On 11/11/2015 01:11 PM, Mike Frysinger wrote: >> On 11 Nov 2015 13:04, Zac Medico wrote: >>> On 11/11/2015 12:55 PM, Mike Frysinger wrote: On 11 Nov 2015 11:42, Zac Medico wrote: > On 11/10/2015 08:39 PM, Mike Frysinger wrote: >> +# Set up

[gentoo-dev] Re: Revise EAPI 6? (was: [RFC] ban use of base-4 casemods in ebuilds due to locale collation instability)

2015-11-11 Thread Martin Vaeth
Jason A. Donenfeld wrote: > > I'd be in favor of full-on LC_ALL=C. Setting LC_ALL seems wrong as it is meant as a quick hack and should not be relied on by a "generic" tool like portage. Better define to *unset* LC_ALL (remembering the previous value, see below) and to set

[gentoo-portage-dev] [PATCH] egencache: parallelize --update-changelogs (bug 565540)

2015-11-11 Thread Zac Medico
Use the TaskScheduler class to parallelize GenChangeLogs. Fix AsyncFunction so it does not re-define 'args' in __slots__. X-Gentoo-Bug: 565540 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=565540 --- bin/egencache| 24 +++-

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-11 Thread Zac Medico
On 11/10/2015 08:39 PM, Mike Frysinger wrote: > To try and provide better stability across bash versions, > set the language compat level based on the current EAPI. > --- > bin/eapi.sh | 8 > bin/ebuild.sh | 39 +++ > 2 files changed, 47

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-11 Thread Mike Frysinger
On 11 Nov 2015 13:04, Zac Medico wrote: > On 11/11/2015 12:55 PM, Mike Frysinger wrote: > > On 11 Nov 2015 11:42, Zac Medico wrote: > >> On 11/10/2015 08:39 PM, Mike Frysinger wrote: > >>> +# Set up the bash version compatibility level. > >>> +__check_bash_version() { > >> > >> Please unset all

[gentoo-portage-dev] [PATCH] Warn if LC_CTYPE does not toupper()/tolower() ASCII chars correctly

2015-11-11 Thread Michał Górny
Output a warning if LC_CTYPE is set to a value that causes libc toupper() and/or tolower() conversions not apply correctly to printable ASCII characters. --- pym/_emerge/actions.py | 40 1 file changed, 40 insertions(+) diff --git a/pym/_emerge/actions.py

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-11 Thread Mike Frysinger
On 11 Nov 2015 11:42, Zac Medico wrote: > On 11/10/2015 08:39 PM, Mike Frysinger wrote: > > +# Set up the bash version compatibility level. > > +__check_bash_version() { > > Please unset all new internal function inside bin/save-ebuild-env.sh. > Note that it already uses this line to unset

[gentoo-portage-dev] [PATCH v2] ebuild: set up bash compat levels

2015-11-11 Thread Mike Frysinger
To try and provide better stability across bash versions, set the language compat level based on the current EAPI. This does not ban newer features, it tells bash to use the older bash behavior when the behavior changes across versions. --- bin/eapi.sh| 8 bin/ebuild.sh

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-11 Thread Zac Medico
On 11/11/2015 12:55 PM, Mike Frysinger wrote: > On 11 Nov 2015 11:42, Zac Medico wrote: >> On 11/10/2015 08:39 PM, Mike Frysinger wrote: >>> +# Set up the bash version compatibility level. >>> +__check_bash_version() { >> >> Please unset all new internal function inside bin/save-ebuild-env.sh. >>

Re: [gentoo-dev] Revise EAPI 6? (was: [RFC] ban use of base-4 casemods in ebuilds due to locale collation instability)

2015-11-11 Thread Jason A. Donenfeld
I'd be in favor of full-on LC_ALL=C. Ebuilds are meant for having a particular determinism. They're machine scripts. The operations they do need to be consistent. For user-facing parts, such as printing information, or sorting user-shown text, I can understand ebuild authors might want in some

Re: [gentoo-dev] Revise EAPI 6?

2015-11-11 Thread Matthias Maier
On Wed, Nov 11, 2015, at 15:52 CST, "Jason A. Donenfeld" wrote: > I'd be in favor of full-on LC_ALL=C. ++ I'm surprised that we do not have such a policy already. Best, Matthias

Re: [gentoo-dev] ChangeLog - Infra Response; update 2015/11/11, potential impact to 30min rsync cycle

2015-11-11 Thread Robin H. Johnson
On Thu, Nov 05, 2015 at 12:54:06PM +0100, Alexis Ballier wrote: > It's not perfectly clean but I don't see any problem here: > ChangeLog-2015 : all ChangeLog from CVS > ChangeLog: autogenerated from git FYI, this was implemented. For reference, the old CVS changelogs are now taken from HEAD of

Re: [gentoo-dev] Revise EAPI 6?

2015-11-11 Thread Ulrich Mueller
> On Wed, 11 Nov 2015, Matthias Maier wrote: > On Wed, Nov 11, 2015, at 15:52 CST, "Jason A. Donenfeld" > wrote: >> I'd be in favor of full-on LC_ALL=C. > ++ > I'm surprised that we do not have such a policy already. LC_ALL=C would disable UTF-8, and I am told that

[gentoo-portage-dev] [PATCH] egencache: fix results when GIT_DIR is used in the environment.

2015-11-11 Thread robbat2
From: "Robin H. Johnson" If GIT_DIR is used, and .git is outside the root of the checkout, then --work-tree=... needs to be specified, otherwise any Git command that relies on relative directories to the root will be wrong. Signed-off-by: Robin H. Johnson

Re: [gentoo-dev] [RFC] ban use of base-4 casemods in ebuilds due to locale collation instability

2015-11-11 Thread Ulrich Mueller
> On Wed, 11 Nov 2015, Mike Frysinger wrote: >> This is wrong on so many levels. :( It starts with the fact that the >> dot over the lowercase latin i historically never was a diacritical >> mark [1]. >> >> Maybe we should advise users in our documentaion that they should >> avoid such