Re: [gentoo-dev] [RFC] Portage einfo, elog... output format change

2021-09-28 Thread Hank Leininger
On 2021-09-28, Ulrich Mueller wrote: > > On Tue, 28 Sep 2021, Michał Górny wrote: > > On Tue, 2021-09-28 at 18:26 +0200, Ulrich Mueller wrote: > >> Markers: (--) probed, (**) from config file, (==) default > >> setting, > >> (++) from command line, (!!) notice, (II)

[gentoo-dev] Package up for grabs: >=app-emulation/docker-compose-2.0.0 (1.x.x was Python, 2.0.0 is Go)

2021-09-28 Thread Sebastian Pipping
Hi! docker-compose upstream has apparently re-written docker-compose in Golang from scratch. While I'm happy to keep maintaining the current python-based =2.0.0 in Gentoo. Thanks in advance! Best Sebastian

Re: [gentoo-dev] [RFC] Portage einfo, elog... output format change

2021-09-28 Thread Ulrich Mueller
> On Tue, 28 Sep 2021, Michał Górny wrote: > On Tue, 2021-09-28 at 18:26 +0200, Ulrich Mueller wrote: >> Markers: (--) probed, (**) from config file, (==) default setting, >> (++) from command line, (!!) notice, (II) informational, >> (WW) warning, (EE) error, (NI) not

Re: [gentoo-dev] [RFC] Portage einfo, elog... output format change

2021-09-28 Thread Michał Górny
On Tue, 2021-09-28 at 18:26 +0200, Ulrich Mueller wrote: > > > > > > On Tue, 28 Sep 2021, Michał Górny wrote: > > > The proposed new format distinguished message types both using > > colors > > and strings. This is roughly inspired by Xorg logs. > > Using the same markers as Xorg (especially

Re: [gentoo-dev] [RFC] Portage einfo, elog... output format change

2021-09-28 Thread Ulrich Mueller
> On Tue, 28 Sep 2021, Michał Górny wrote: > The proposed new format distinguished message types both using colors > and strings. This is roughly inspired by Xorg logs. Using the same markers as Xorg (especially [--]) but with different meaning may be confusing though. Xorg has these:

Re: [gentoo-dev] [RFC] Portage einfo, elog... output format change

2021-09-28 Thread Wolfgang E. Sanyer
I love it - this is similar to the xorg log output, and i think it makes the portage output much cleaner and easier to read. El mar., 28 de septiembre de 2021 11:36 a. m., Michał Górny < mgo...@gentoo.org> escribió: > Hi, everyone. > > I know I'm going to regret asking this... but I've prepared

Re: [gentoo-portage-dev] [PATCH 0/4] Output rewrite for better clarify and greppability

2021-09-28 Thread Michał Górny
On Tue, 2021-09-28 at 11:28 -0400, Mike Gilbert wrote: > On Tue, Sep 28, 2021 at 10:20 AM Michał Górny wrote: > > > > Hi, > > > > Ok, so it's more major than I originally intended but I think it's > > a good direction (once you get used to it). Roughly: > > > > 1. All bash color vars are now

[gentoo-dev] [RFC] Portage einfo, elog... output format change

2021-09-28 Thread Michał Górny
Hi, everyone. I know I'm going to regret asking this... but I've prepared a change to the Portage output format and I think it asks for a wider discussion than internally in Portage team. The primary problem with the current output format is that different kinds of messages differ only in color.

Re: [gentoo-portage-dev] [PATCH 0/4] Output rewrite for better clarify and greppability

2021-09-28 Thread Mike Gilbert
On Tue, Sep 28, 2021 at 10:20 AM Michał Górny wrote: > > Hi, > > Ok, so it's more major than I originally intended but I think it's > a good direction (once you get used to it). Roughly: > > 1. All bash color vars are now prefixed with `PORTAGE_COLOR_` to avoid >accidental collisions with

[gentoo-portage-dev] [PATCH 3/4] Use verbose prefixes for output messages

2021-09-28 Thread Michał Górny
Use verbose prefixes for output functions einfo, elog... in order to make the message types distinguishable on non-color terminals, and to enable the possibility of grepping them. The prefixes are roughly inspired by Xorg logs, and are: - `[--]` for einfo (and ebegin) - `[II]` for elog - `[WW]`

[gentoo-portage-dev] [PATCH 2/4] Use distinct colors for output msg types

2021-09-28 Thread Michał Górny
Introduce distinct colors per output function. For elog and eerror the colors remain the same but the names change. For einfo and eqawarn, use darker colors to distinguish them. Signed-off-by: Michał Górny --- bin/isolated-functions.sh| 30 +++--- bin/save-ebuild-env.sh

[gentoo-portage-dev] [PATCH 1/4] Prefix color vars with "PORTAGE_COLOR_"

2021-09-28 Thread Michał Górny
Rename color variables used by einfo etc. to use "PORTAGE_COLOR_" prefix. Currently these variables are prone to being accidentally ovewritten e.g. if an ebuild uses GOOD or BAD variables for some purpose. Using PORTAGE prefix should keep us safe. As an extra benefit, this makes it trivial to

[gentoo-portage-dev] [PATCH 0/4] Output rewrite for better clarify and greppability

2021-09-28 Thread Michał Górny
Hi, Ok, so it's more major than I originally intended but I think it's a good direction (once you get used to it). Roughly: 1. All bash color vars are now prefixed with `PORTAGE_COLOR_` to avoid accidental collisions with ebuild vars (e.g. ebuild setting `GOOD=foo` broke `elog` before). 2.

Re: [gentoo-dev] Guidance on adding kernel config checks to ebuilds

2021-09-28 Thread Michael Orlitzky
On Mon, 2021-09-27 at 15:44 -0400, Mike Gilbert wrote: > On Mon, Sep 27, 2021 at 3:11 PM Peter Stuge wrote: > > > > Mike Gilbert wrote: > > > It's a waste of time and effort to pepper random ebuilds with checks > > > for options that everyone should have enabled in the first place. > > > > It's

Re: [gentoo-portage-dev] [PATCH] install-qa-check.d: Add a QA check for installing xattrs

2021-09-28 Thread Mike Gilbert
On Tue, Sep 28, 2021 at 2:25 AM Michał Górny wrote: > > On Mon, 2021-09-27 at 21:09 -0400, Mike Gilbert wrote: > > On Mon, Sep 27, 2021 at 1:20 PM Michał Górny wrote: > > > + eqawarn > > > + eqawarn "It is impossible to reliably guarantee that the > > > extended

[gentoo-portage-dev] [PATCH v2] install-qa-check.d: Add a QA check for installing xattrs

2021-09-28 Thread Michał Górny
Warn the developers if ebuilds install files with xattrs to ${ED}. The xattrs may or may not be preserved when installing the package, making them unreliable on one hand, and somewhat suprising in other cases (e.g. when they unintentionally leak from developer's system). This is the first step

Re: [gentoo-portage-dev] [PATCH] install-qa-check.d: Add a QA check for installing xattrs

2021-09-28 Thread Michał Górny
On Mon, 2021-09-27 at 21:09 -0400, Mike Gilbert wrote: > On Mon, Sep 27, 2021 at 1:20 PM Michał Górny wrote: > > + eqawarn > > + eqawarn "It is impossible to reliably guarantee that the > > extended attributes" > > + eqawarn "will be reliably preserved

Re: [gentoo-portage-dev] [PATCH] install-qa-check.d: Add a QA check for installing xattrs

2021-09-28 Thread Michał Górny
On Mon, 2021-09-27 at 21:03 -0400, Mike Gilbert wrote: > On Mon, Sep 27, 2021 at 1:20 PM Michał Górny wrote: > > > > Warn the developers if ebuilds install files with xattrs to ${ED}. > > The xattrs may or may not be preserved when installing the package, > > making them unreliable on one hand,