Re: [gentoo-dev] [PATCH] savedconfig.eclass: do not preserve symlink in restore_config

2023-06-04 Thread Michael Orlitzky
On Sun, 2023-06-04 at 20:46 +0200, Arsen Arsenović wrote: > > I believe that the target directory of this cp can be considered > equivalent in terms of access to any superuser-only directory, so I'm > not sure I see the problem with this change. It silently changes something that was safe (but

Re: [gentoo-dev] [PATCH] savedconfig.eclass: do not preserve symlink in restore_config

2023-06-04 Thread Arsen Arsenović
Michael Orlitzky writes: > If so, the symlink should point to a superuser-only location to avoid > creating any new vulnerabilities. We can't fix the general problem, but > we could at least mention in the docs that symlinks will (now) be > followed and that users should be careful if they want

Re: [gentoo-dev] [PATCH] savedconfig.eclass: do not preserve symlink in restore_config

2023-06-04 Thread Mike Gilbert
On Sun, Jun 4, 2023 at 2:03 PM Michael Orlitzky wrote: > > On Sun, 2023-06-04 at 13:31 -0400, Mike Gilbert wrote: > > This allows users to maintain the saved config file in some other > > location. > > > > If so, the symlink should point to a superuser-only location to avoid > creating any new

Re: [gentoo-dev] [PATCH] savedconfig.eclass: do not preserve symlink in restore_config

2023-06-04 Thread Michael Orlitzky
On Sun, 2023-06-04 at 13:31 -0400, Mike Gilbert wrote: > This allows users to maintain the saved config file in some other > location. > If so, the symlink should point to a superuser-only location to avoid creating any new vulnerabilities. We can't fix the general problem, but we could at least

[gentoo-dev] [PATCH] savedconfig.eclass: do not preserve symlink in restore_config

2023-06-04 Thread Mike Gilbert
This allows users to maintain the saved config file in some other location. Also drop the recursive (-R) option; this cp command is only executed when we are restoring a single regular file. Closes: https://bugs.gentoo.org/907696 Signed-off-by: Mike Gilbert --- eclass/savedconfig.eclass | 4

[gentoo-dev] [PATCH] qmake-utils.eclass: Force QMAKE_*FLAGS_RELEASE_WITH_DEBUGINFO to blank

2023-06-04 Thread James Le Cuirot
These variables are usually defined as: $ fgrep RELEASE_WITH_DEBUGINFO /usr/lib64/qt5/mkspecs/common/gcc-base.conf QMAKE_CFLAGS_RELEASE_WITH_DEBUGINFO += $$QMAKE_CFLAGS_OPTIMIZE -g QMAKE_CXXFLAGS_RELEASE_WITH_DEBUGINFO += $$QMAKE_CFLAGS_RELEASE_WITH_DEBUGINFO