> On Fri, 08 Sep 2023, Michał Górny wrote:
>> > + ! has "${filename}" "${files[@]}" && continue
>>
>> This might be clearer if it was written as:
>>
>> has "${filename}" "${files[@]}" || continue
> Negative logic is never clearer.
Exactly. That's why we generally do "command ||
Michał Górny writes:
> Signed-off-by: Michał Górny
The lot lgtm with Bug/Closes tags for https://bugs.gentoo.org/913394.
> ---
> eclass/tests/verify-sig.sh | 65 ++
> 1 file changed, 65 insertions(+)
> create mode 100755 eclass/tests/verify-sig.sh
>
>
Thanks to ulm for reporting.
Signed-off-by: Michał Górny
---
eclass/verify-sig.eclass | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/eclass/verify-sig.eclass b/eclass/verify-sig.eclass
index 010361bfbc98..49557b633c87 100644
--- a/eclass/verify-sig.eclass
+++
Signed-off-by: Michał Górny
---
eclass/tests/verify-sig.sh | 11 +++
eclass/verify-sig.eclass | 5 +++--
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/eclass/tests/verify-sig.sh b/eclass/tests/verify-sig.sh
index fb7f2cdb2a5d..a87e2c7703d7 100755
---
Signed-off-by: Michał Górny
---
eclass/tests/verify-sig.sh | 18 +
eclass/verify-sig.eclass | 54 +-
2 files changed, 54 insertions(+), 18 deletions(-)
Changes:
- referring to the var as `format` consistently
- fixed eclassdoc
- used explicit
Signed-off-by: Michał Górny
---
eclass/tests/verify-sig.sh | 65 ++
1 file changed, 65 insertions(+)
create mode 100755 eclass/tests/verify-sig.sh
diff --git a/eclass/tests/verify-sig.sh b/eclass/tests/verify-sig.sh
new file mode 100755
index
On Fri, 2023-09-08 at 12:03 +0200, Michał Górny wrote:
> On Mon, 2023-09-04 at 08:42 +0200, Ulrich Mueller wrote:
> > > > > > > On Mon, 04 Sep 2023, Michał Górny wrote:
> >
> > > --- a/eclass/verify-sig.eclass
> > > +++ b/eclass/verify-sig.eclass
> > > @@ -214,12 +214,15 @@
On Mon, 2023-09-04 at 08:42 +0200, Ulrich Mueller wrote:
> > > > > > On Mon, 04 Sep 2023, Michał Górny wrote:
>
> > --- a/eclass/verify-sig.eclass
> > +++ b/eclass/verify-sig.eclass
> > @@ -214,12 +214,15 @@ verify-sig_verify_message() {
> > }
>
>
>
>
> > # @FUNCTION:
