Re: [gentoo-dev] [PATCH] python-utils-r1.eclass: epytest, use NO_COLOR rather than NOCOLOR

On 12/11/23 21:38, Ulrich Mueller wrote: The standard is defined by sno-color.org. http://no-color.org -- Toralf PGP 23217DA7 9B888F45 OpenPGP_signature.asc Description: OpenPGP digital signature

Re: [gentoo-dev] [PATCH] python-utils-r1.eclass: epytest, use NO_COLOR rather than NOCOLOR

> On Mon, 11 Dec 2023, Eli Schwartz wrote: >> "Command-line software which adds ANSI color to its output by default >> should check for a NO_COLOR environment variable that, when present >> and not an empty string (regardless of its value), prevents the >> addition of ANSI color." --

Re: [gentoo-dev] [PATCH] python-utils-r1.eclass: epytest, use NO_COLOR rather than NOCOLOR

On 12/11/23 2:27 PM, Michał Górny wrote: > That looks wrong. Per [1]: > >> […] NO_COLOR environment variable that, when present and not an empty > string (regardless of its value), prevents the addition of ANSI color. > > So hey, I'm actually fixing pytest ;-). > > [1] https://no-color.org/

Re: [gentoo-dev] [PATCH] python-utils-r1.eclass: epytest, use NO_COLOR rather than NOCOLOR

On 12/11/23 2:30 PM, Ulrich Mueller wrote: >> On Mon, 11 Dec 2023, Eli Schwartz wrote: > >>> + local color=yes >>> + [[ ${NO_COLOR} ]] && color=no > >> [[ -v NO_COLOR ]] > > No, this would give the wrong result if NO_COLOR is set to an empty > value. [[ ${NO_COLOR} ]] or [[ -n

Re: [gentoo-dev] [PATCH] python-utils-r1.eclass: epytest, use NO_COLOR rather than NOCOLOR

> On Mon, 11 Dec 2023, Eli Schwartz wrote: >> +local color=yes >> +[[ ${NO_COLOR} ]] && color=no > [[ -v NO_COLOR ]] No, this would give the wrong result if NO_COLOR is set to an empty value. [[ ${NO_COLOR} ]] or [[ -n ${NO_COLOR} ]] is the correct test: "Command-line software

Re: [gentoo-dev] [PATCH] python-utils-r1.eclass: epytest, use NO_COLOR rather than NOCOLOR

On Mon, 2023-12-11 at 13:57 -0500, Eli Schwartz wrote: > On 12/2/23 7:44 AM, Michał Górny wrote: > > Update epytest to respect the modern NO_COLOR variable rather than > > Portage's old NOCOLOR. Adjust it to correctly check whether it is set > > at all rather than to a specific value, to match

Re: [gentoo-dev] [PATCH] python-utils-r1.eclass: epytest, use NO_COLOR rather than NOCOLOR

On 12/2/23 7:44 AM, Michał Górny wrote: > Update epytest to respect the modern NO_COLOR variable rather than > Portage's old NOCOLOR. Adjust it to correctly check whether it is set > at all rather than to a specific value, to match the behavior of pytest > itself. > > Signed-off-by: Michał Górny

Re: [gentoo-dev] heads up: codeberg changed gzip impls (?) for ${REPO}/archive/${TAG}.tar.gz files

On 12/11/23 5:47 AM, Arsen Arsenović wrote: > hi, > > it seems that codeberg has changed how they produce their archives on > URLs like leading > to digest failures like , as implied by > the following checks:

Re: [gentoo-dev] heads up: codeberg changed gzip impls (?) for ${REPO}/archive/${TAG}.tar.gz files

Arsen Arsenović writes: > hi, > > it seems that codeberg has changed how they produce their archives on > URLs like leading > to digest failures like , as implied by > the following checks: > > ~$ diff <(

Re: [gentoo-dev] [PATCH v4] kernel-build.eclass: work around permissions issue with module signing

On Mon, 2023-12-11 at 12:28 +0100, Andrew Ammerlaan wrote: > > > diff --git a/eclass/kernel-build.eclass b/eclass/kernel-build.eclass > > > index f5529c319f9fc..94b499f82fc1e 100644 > > > --- a/eclass/kernel-build.eclass > > > +++ b/eclass/kernel-build.eclass > > > @@ -114,6 +114,13 @@

Re: [gentoo-dev] [PATCH v2] kernel-install.eclass: fix test phase on systemd systems

On Mon, 2023-12-11 at 12:22 +0100, Andrew Ammerlaan wrote: > > > + # Initrd images with systemd require some os-release file > > > + cat <<-EOT >> "${imageroot}/etc/os-release" || die > > > + NAME=Gentoo > > > + ID=gentoo > > > + PRETTY_NAME="Gentoo Linux" > > > + ANSI_COLOR="1;32" > > > +

Re: [gentoo-dev] [PATCH v4] kernel-build.eclass: work around permissions issue with module signing

diff --git a/eclass/kernel-build.eclass b/eclass/kernel-build.eclass index f5529c319f9fc..94b499f82fc1e 100644 --- a/eclass/kernel-build.eclass +++ b/eclass/kernel-build.eclass @@ -114,6 +114,13 @@ kernel-build_pkg_setup() { python-any-r1_pkg_setup if [[

Re: [gentoo-dev] [PATCH v2] kernel-install.eclass: fix test phase on systemd systems

+ # Initrd images with systemd require some os-release file + cat <<-EOT >> "${imageroot}/etc/os-release" || die + NAME=Gentoo + ID=gentoo + PRETTY_NAME="Gentoo Linux" + ANSI_COLOR="1;32" + HOME_URL="https://www.gentoo.org/; +

Re: [gentoo-dev] [PATCH v3] kernel-build.eclass: work around permissions issue with module signing

On Mon, 2023-12-11 at 09:00 +0100, Andrew Ammerlaan wrote: > v3: > > From dbf92605437b4a457bad2da92f69baab23fcfa44 Mon Sep 17 00:00:00 2001 > From: Violet Purcell > Date: Mon, 27 Nov 2023 12:12:09 -0500 > Subject: [PATCH] kernel-build.eclass: work around permissions issue with > module

Re: [gentoo-dev] [PATCH] kernel-install.eclass: fix test phase on systemd systems

On Mon, 2023-12-11 at 08:43 +0100, Andrew Ammerlaan wrote: > Patch is part of https://github.com/gentoo/gentoo/pull/34024 > > Best regards, > Andrew > > From 03e17149eef9eba08f8c8bf32845c18106d32290 Mon Sep 17 00:00:00 2001 > From: Andrew Ammerlaan > Date: Mon, 11 Dec 2023 08:36:58 +0100 >

[gentoo-dev] heads up: codeberg changed gzip impls (?) for ${REPO}/archive/${TAG}.tar.gz files

hi, it seems that codeberg has changed how they produce their archives on URLs like leading to digest failures like , as implied by the following checks: ~$ diff <( signature.asc Description: PGP signature

Re: [gentoo-dev] [PATCH v3] kernel-build.eclass: work around permissions issue with module signing

v3: From dbf92605437b4a457bad2da92f69baab23fcfa44 Mon Sep 17 00:00:00 2001 From: Violet Purcell Date: Mon, 27 Nov 2023 12:12:09 -0500 Subject: [PATCH] kernel-build.eclass: work around permissions issue with module signing Currently, using a custom path for MODULES_SIGN_KEY requires the key to