Re: [gentoo-dev] [PATCH] app-portage/eclass-manpages: @DEFAULT_UNSET -> @DEFAULT-UNSET

2017-05-01 Thread Ulrich Mueller
> On Mon, 01 May 2017, Michał Górny wrote: > You are confusing constructive criticism with meaningless style > bikeshed which serves no purpose except creating more work on > everyone. What's creating more work for everybody is changing the name of the token. All I was saying was that

Re: [gentoo-dev] [PATCH] app-portage/eclass-manpages: @DEFAULT_UNSET -> @DEFAULT-UNSET

2017-05-01 Thread Michał Górny
Dnia 1 maja 2017 09:32:40 CEST, Ulrich Mueller napisał(a): >> On Sun, 30 Apr 2017, Michał Górny wrote: > >> From now on I'm not going to listen to any suggestions that do not >> come with a patch. > >You have posted a patch for review. So IMHO, asking others to do the >work

Re: [gentoo-dev] [PATCH] app-portage/eclass-manpages: @DEFAULT_UNSET -> @DEFAULT-UNSET

2017-05-01 Thread Ulrich Mueller
> On Sun, 30 Apr 2017, Michał Górny wrote: > From now on I'm not going to listen to any suggestions that do not > come with a patch. You have posted a patch for review. So IMHO, asking others to do the work when you receive criticism isn't a reasonable request. All the more since the

Re: [gentoo-dev] [PATCH] app-portage/eclass-manpages: @DEFAULT_UNSET -> @DEFAULT-UNSET

2017-04-30 Thread Michał Górny
On sob, 2017-04-29 at 14:05 -0400, Davide Pesavento wrote: > On Sat, Apr 29, 2017 at 1:40 PM, Michał Górny wrote: > > Dnia 29 kwietnia 2017 19:23:49 CEST, Davide Pesavento > > napisał(a): > > > On Sat, Apr 29, 2017 at 1:57 AM, Michał Górny

Re: [gentoo-dev] [PATCH] app-portage/eclass-manpages: @DEFAULT_UNSET -> @DEFAULT-UNSET

2017-04-30 Thread Michał Górny
On nie, 2017-04-30 at 06:03 +1200, Kent Fredric wrote: > On Fri, 28 Apr 2017 16:39:45 +0200 > Michał Górny wrote: > > > Change the unset value tag to '@DEFAULT-UNSET' to ensure consistent > > use of hyphen/underscore throughout eclassdoc. Before, one tag > > (@ECLASS-VARIABLE)

Re: [gentoo-dev] [PATCH] app-portage/eclass-manpages: @DEFAULT_UNSET -> @DEFAULT-UNSET

2017-04-29 Thread Davide Pesavento
On Sat, Apr 29, 2017 at 1:40 PM, Michał Górny wrote: > Dnia 29 kwietnia 2017 19:23:49 CEST, Davide Pesavento > napisał(a): >>On Sat, Apr 29, 2017 at 1:57 AM, Michał Górny >>wrote: >>> On sob, 2017-04-29 at 05:41 +0200, Ulrich Mueller

Re: [gentoo-dev] [PATCH] app-portage/eclass-manpages: @DEFAULT_UNSET -> @DEFAULT-UNSET

2017-04-29 Thread Kent Fredric
On Fri, 28 Apr 2017 16:39:45 +0200 Michał Górny wrote: > Change the unset value tag to '@DEFAULT-UNSET' to ensure consistent > use of hyphen/underscore throughout eclassdoc. Before, one tag > (@ECLASS-VARIABLE) has used hyphen while also one (@DEFAULT_UNSET) > used underscore.

Re: [gentoo-dev] [PATCH] app-portage/eclass-manpages: @DEFAULT_UNSET -> @DEFAULT-UNSET

2017-04-29 Thread Michał Górny
Dnia 29 kwietnia 2017 19:23:49 CEST, Davide Pesavento napisał(a): >On Sat, Apr 29, 2017 at 1:57 AM, Michał Górny >wrote: >> On sob, 2017-04-29 at 05:41 +0200, Ulrich Mueller wrote: >>> > > > > > On Fri, 28 Apr 2017, Michał Górny wrote: >>> > (and hyphens do

Re: [gentoo-dev] [PATCH] app-portage/eclass-manpages: @DEFAULT_UNSET -> @DEFAULT-UNSET

2017-04-29 Thread Davide Pesavento
On Sat, Apr 29, 2017 at 1:57 AM, Michał Górny wrote: > On sob, 2017-04-29 at 05:41 +0200, Ulrich Mueller wrote: >> > > > > > On Fri, 28 Apr 2017, Michał Górny wrote: >> > (and hyphens do not require holding shift). >> >> So they are awkward to type inside a string that is

Re: [gentoo-dev] [PATCH] app-portage/eclass-manpages: @DEFAULT_UNSET -> @DEFAULT-UNSET

2017-04-28 Thread Michał Górny
On sob, 2017-04-29 at 05:41 +0200, Ulrich Mueller wrote: > > > > > > On Fri, 28 Apr 2017, Michał Górny wrote: > > (and hyphens do not require holding shift). > > So they are awkward to type inside a string that is all-caps? > Funny enough, yes. I naturally let shift go when pushing '-' ;-).

Re: [gentoo-dev] [PATCH] app-portage/eclass-manpages: @DEFAULT_UNSET -> @DEFAULT-UNSET

2017-04-28 Thread Ulrich Mueller
> On Fri, 28 Apr 2017, Michał Górny wrote: > (and hyphens do not require holding shift). So they are awkward to type inside a string that is all-caps? Ulrich pgpcPtuzpVLxT.pgp Description: PGP signature

[gentoo-dev] [PATCH] app-portage/eclass-manpages: @DEFAULT_UNSET -> @DEFAULT-UNSET

2017-04-28 Thread Michał Górny
Change the unset value tag to '@DEFAULT-UNSET' to ensure consistent use of hyphen/underscore throughout eclassdoc. Before, one tag (@ECLASS-VARIABLE) has used hyphen while also one (@DEFAULT_UNSET) used underscore. Unify them to use the former since @ECLASS-VARIABLE tag is more common (and hyphens