Re: [gentoo-dev] [PATCH] eutils.eclass: In EAPI conditionals, replace "has" by case statements.

2015-11-30 Thread Michał Górny
, Dnia 30 listopada 2015 07:52:59 CET, Ulrich Mueller napisał(a): >> On Mon, 30 Nov 2015, Davide Pesavento wrote: > >>> The patch below replaces them by case statements. (Unfortunately we >>> cannot use fall-through (&;) because it is a bash 4 feature.) > >> Sounds

Re: [gentoo-dev] [PATCH] eutils.eclass: In EAPI conditionals, replace "has" by case statements.

2015-11-30 Thread Davide Pesavento
On Mon, Nov 30, 2015 at 7:52 AM, Ulrich Mueller wrote: >> On Mon, 30 Nov 2015, Davide Pesavento wrote: > >>> The patch below replaces them by case statements. (Unfortunately we >>> cannot use fall-through (&;) because it is a bash 4 feature.) > >> Sounds reasonable, although

[gentoo-dev] [PATCH] eutils.eclass: In EAPI conditionals, replace "has" by case statements.

2015-11-29 Thread Ulrich Mueller
As suggested by mgorny, we could use bash internals instead of the "has" function calls in global scope. The patch below replaces them by case statements. (Unfortunately we cannot use fall-through (&;) because it is a bash 4 feature.) Ulrich From 89e837f5179354aa3dfa454f51282ad9d1143402 Mon

Re: [gentoo-dev] [PATCH] eutils.eclass: In EAPI conditionals, replace "has" by case statements.

2015-11-29 Thread Davide Pesavento
On Sun, Nov 29, 2015 at 5:48 PM, Ulrich Mueller wrote: > As suggested by mgorny, we could use bash internals instead of the > "has" function calls in global scope. > > The patch below replaces them by case statements. (Unfortunately we > cannot use fall-through (&;) because it is

Re: [gentoo-dev] [PATCH] eutils.eclass: In EAPI conditionals, replace "has" by case statements.

2015-11-29 Thread Ulrich Mueller
> On Mon, 30 Nov 2015, Davide Pesavento wrote: >> The patch below replaces them by case statements. (Unfortunately we >> cannot use fall-through (&;) because it is a bash 4 feature.) > Sounds reasonable, although I'd find an 'if' clause slightly more > readable, since there wouldn't be an