Re: [gentoo-dev] [PATCH] linux-info.eclass: avoid lexicographical compare on numbers, bug #705248

2020-05-23 Thread Sergei Trofimovich
On Sat, 23 May 2020 14:56:06 -0400 Mike wrote: > On 5/22/20 2:57 PM, Sergei Trofimovich wrote: > > Originally found in bug #705240 as: > > > > ``` > > error=0 > > ... > > if [[ ${error} > 0 ]]; then > > ... > > ``` > > > > '>' are string comparisons. They are benign in this case, but

Re: [gentoo-dev] [PATCH] linux-info.eclass: avoid lexicographical compare on numbers, bug #705248

2020-05-23 Thread Mike
On 5/22/20 2:57 PM, Sergei Trofimovich wrote: > Originally found in bug #705240 as: > > ``` > error=0 > ... > if [[ ${error} > 0 ]]; then > ... > ``` > > '>' are string comparisons. They are benign in this case, but let's > be consistent and use integer comparison. > > CC:

[gentoo-dev] [PATCH] linux-info.eclass: avoid lexicographical compare on numbers, bug #705248

2020-05-22 Thread Sergei Trofimovich
Originally found in bug #705240 as: ``` error=0 ... if [[ ${error} > 0 ]]; then ... ``` '>' are string comparisons. They are benign in this case, but let's be consistent and use integer comparison. CC: ker...@gentoo.org Closes: https://bugs.gentoo.org/705248 Signed-off-by: Sergei