Re: [gentoo-dev] [PATCH] meson.eclass: allow disabling verbose compilation

2023-07-17 Thread Matt Turner
On Mon, Jul 17, 2023 at 10:56 AM Adrian Schollmeyer wrote: > Am Montag, dem 17.07.2023 um 10:51 -0400 schrieb Matt Turner: > > This works similar to cmake.eclass's ${CMAKE_VERBOSE}. > > Why not use MESON_VERBOSE as well? Avoids double negation in the code > (not unset -> verbose vs. MESON_VERBOSE

Re: [gentoo-dev] [PATCH] meson.eclass: allow disabling verbose compilation

2023-07-17 Thread Adrian Schollmeyer
Hi, Am Montag, dem 17.07.2023 um 10:51 -0400 schrieb Matt Turner: > This works similar to cmake.eclass's ${CMAKE_VERBOSE}. Why not use MESON_VERBOSE as well? Avoids double negation in the code (not unset -> verbose vs. MESON_VERBOSE == true -> verbose) and keeps the variable naming similar to

[gentoo-dev] [PATCH] meson.eclass: allow disabling verbose compilation

2023-07-17 Thread Matt Turner
From: Jonas Rakebrandt This works similar to cmake.eclass's ${CMAKE_VERBOSE}. Closes: https://github.com/gentoo/gentoo/pull/28942 Signed-off-by: Jonas Rakebrandt Signed-off-by: Matt Turner --- eclass/meson.eclass | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff