Re: [gentoo-dev] [PATCH 1/2] distutils-r1.eclass: teach setuptools to respect (some) build options

2023-09-14 Thread Ulrich Mueller
> On Wed, 13 Sep 2023, Eli Schwartz wrote: >> That's a rather bold statement. I can imagine a number of possible >> failures, e.g. no space left on device, quota exceeded, or a low-level >> I/O error of the filesystem. Also fork or exec of the cat command could >> fail (e.g. out of memory).

Re: [gentoo-dev] [PATCH 1/2] distutils-r1.eclass: teach setuptools to respect (some) build options

2023-09-13 Thread Eli Schwartz
On 9/13/23 9:10 AM, Michael Orlitzky wrote: > On Tue, 2023-09-12 at 22:52 -0400, Eli Schwartz wrote: >> >> Is portage generally expected to successfully complete (including >> internal metadata write stages) when its workdir drive runs out of space >> partway through? >> > > No, but I think what

Re: [gentoo-dev] [PATCH 1/2] distutils-r1.eclass: teach setuptools to respect (some) build options

2023-09-13 Thread Eli Schwartz
On 9/13/23 5:27 AM, Ulrich Mueller wrote: >> On Wed, 13 Sep 2023, Eli Schwartz wrote: > >>> "|| die" should also be added for the cat command. > >> Redirecting output to a file in a directory you have just guaranteed >> to exist cannot fail. > > That's a rather bold statement. I can imagine

Re: [gentoo-dev] [PATCH 1/2] distutils-r1.eclass: teach setuptools to respect (some) build options

2023-09-13 Thread Michael Orlitzky
On Tue, 2023-09-12 at 22:52 -0400, Eli Schwartz wrote: > > Is portage generally expected to successfully complete (including > internal metadata write stages) when its workdir drive runs out of space > partway through? > No, but I think what everyone else is forgetting to mention is that if

Re: [gentoo-dev] [PATCH 1/2] distutils-r1.eclass: teach setuptools to respect (some) build options

2023-09-13 Thread Ulrich Mueller
> On Wed, 13 Sep 2023, Eli Schwartz wrote: >> "|| die" should also be added for the cat command. > Redirecting output to a file in a directory you have just guaranteed > to exist cannot fail. That's a rather bold statement. I can imagine a number of possible failures, e.g. no space left on

Re: [gentoo-dev] [PATCH 1/2] distutils-r1.eclass: teach setuptools to respect (some) build options

2023-09-13 Thread Alexey Sokolov
13.09.2023 03:52, Eli Schwartz пишет: On 9/12/23 10:26 PM, Michał Górny wrote: On Tue, 2023-09-12 at 22:07 -0400, Eli Schwartz wrote: On 9/12/23 3:56 PM, Ulrich Mueller wrote: On Tue, 12 Sep 2023, Eli Schwartz wrote: + mkdir -p "${BUILD_DIR}" || die +

Re: [gentoo-dev] [PATCH 1/2] distutils-r1.eclass: teach setuptools to respect (some) build options

2023-09-12 Thread Sam James
Eli Schwartz writes: > On 9/12/23 10:26 PM, Michał Górny wrote: >> On Tue, 2023-09-12 at 22:07 -0400, Eli Schwartz wrote: >>> On 9/12/23 3:56 PM, Ulrich Mueller wrote: > On Tue, 12 Sep 2023, Eli Schwartz wrote: > + mkdir -p "${BUILD_DIR}" || die > +

Re: [gentoo-dev] [PATCH 1/2] distutils-r1.eclass: teach setuptools to respect (some) build options

2023-09-12 Thread Eli Schwartz
On 9/12/23 10:26 PM, Michał Górny wrote: > On Tue, 2023-09-12 at 22:07 -0400, Eli Schwartz wrote: >> On 9/12/23 3:56 PM, Ulrich Mueller wrote: On Tue, 12 Sep 2023, Eli Schwartz wrote: >>> + mkdir -p "${BUILD_DIR}" || die + local

Re: [gentoo-dev] [PATCH 1/2] distutils-r1.eclass: teach setuptools to respect (some) build options

2023-09-12 Thread Michał Górny
On Tue, 2023-09-12 at 22:07 -0400, Eli Schwartz wrote: > On 9/12/23 3:56 PM, Ulrich Mueller wrote: > > > > > > > On Tue, 12 Sep 2023, Eli Schwartz wrote: > > > > > + mkdir -p "${BUILD_DIR}" || die > > > + local -x > > >

Re: [gentoo-dev] [PATCH 1/2] distutils-r1.eclass: teach setuptools to respect (some) build options

2023-09-12 Thread Eli Schwartz
On 9/12/23 3:56 PM, Ulrich Mueller wrote: >> On Tue, 12 Sep 2023, Eli Schwartz wrote: > >> +mkdir -p "${BUILD_DIR}" || die >> +local -x >> DIST_EXTRA_CONFIG="${BUILD_DIR}/extra-setup.cfg" >> +cat >

Re: [gentoo-dev] [PATCH 1/2] distutils-r1.eclass: teach setuptools to respect (some) build options

2023-09-12 Thread Ulrich Mueller
> On Tue, 12 Sep 2023, Eli Schwartz wrote: > + mkdir -p "${BUILD_DIR}" || die > + local -x > DIST_EXTRA_CONFIG="${BUILD_DIR}/extra-setup.cfg" > + cat > "${DIST_EXTRA_CONFIG}" <<-EOF > +

[gentoo-dev] [PATCH 1/2] distutils-r1.eclass: teach setuptools to respect (some) build options

2023-09-12 Thread Eli Schwartz
Previously, setup.py was handled by: - manually passing makejobs, with a heuristic to guess whether it was a time saver to do so. - rm -rf'ing the build directory in between python versions to prevent cross-version contamination This is because in PEP 517 mode, it doesn't accept build