Re: [gentoo-dev] [PATCH 1/2] toolchain-funcs.eclass: export tc-get*READELF helpers, bug #725304

2020-05-25 Thread Sergei Trofimovich
On Mon, 25 May 2020 11:30:29 -0400 Mike Gilbert wrote: > On Mon, May 25, 2020 at 9:06 AM Sergei Trofimovich wrote: > > > > Bug: https://bugs.gentoo.org/725304 > > Signed-off-by: Sergei Trofimovich > > Both patches look good to me. > > However, I think you should remove the bug number from

Re: [gentoo-dev] [PATCH 1/2] toolchain-funcs.eclass: export tc-get*READELF helpers, bug #725304

2020-05-25 Thread Mike Gilbert
On Mon, May 25, 2020 at 9:06 AM Sergei Trofimovich wrote: > > Bug: https://bugs.gentoo.org/725304 > Signed-off-by: Sergei Trofimovich Both patches look good to me. However, I think you should remove the bug number from the summary line; it makes the summary too long and the Bug tag later in

[gentoo-dev] [PATCH 1/2] toolchain-funcs.eclass: export tc-get*READELF helpers, bug #725304

2020-05-25 Thread Sergei Trofimovich
Bug: https://bugs.gentoo.org/725304 Signed-off-by: Sergei Trofimovich --- eclass/toolchain-funcs.eclass | 9 + 1 file changed, 9 insertions(+) diff --git a/eclass/toolchain-funcs.eclass b/eclass/toolchain-funcs.eclass index 1bc6cbbc108..709c3baca53 100644 ---