On Tue, 06 Jul 2021 09:34:14 +0200 Ulrich Mueller <u...@gentoo.org> wrote:
> >>>>> On Tue, 06 Jul 2021, Sergei Trofimovich wrote:
>
> > case "${EAPI:-0}" in
>
> This could be just ${EAPI} now (and quotes were never necessary).
>
> > - 0|1) ;;
> > - 2|3|4|5|6|7) HASKELL_CABAL_EXPF+=" src_configure" ;;
> > + 6|7) ;;
> > *) die "EAPI ${EAPI} unsupported." ;;
>
>
> I'd suggest to update to die message to what is used in other eclasses
> (see toolchain-funcs.eclass for example):
>
> *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
>
> > esac
>
> Same comment for the other eclasses of this series.
>
> Ulrich
Sounds good. Done both as:
--- a/eclass/haskell-cabal.eclass
+++ b/eclass/haskell-cabal.eclass
@@ -40,11 +40,11 @@
# FEATURE can be removed once
https://github.com/haskell/cabal/issues/7213
# is fixed.
-case "${EAPI:-0}" in
+case ${EAPI} in
# eutils is for eqawarn
6|7) inherit eutils ;;
8) ;;
- *) die "EAPI ${EAPI} unsupported." ;;
+ *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
esac
inherit ghc-package multilib toolchain-funcs
--
Sergei
pgpf8CE1FGmnS.pgp
Description: Цифровая подпись OpenPGP
