Re: [gentoo-dev] [PATCH 1/7] eclass/dotnet-pkg-base.eclass: quotes and style tweaks for edge cases

2024-02-08 Thread Maciej Barć
Thanks Sam, this is what I added: Subject: [PATCH 1/7] eclass/dotnet-pkg-base.eclass: quotes and style tweaks format special variables in edge cases section of the dotnet-pkg-base eclass Signed-off-by: Maciej Barć Subject: [PATCH 2/7] eclass/dotnet-pkg-base.eclass: deprecate wrong-style

Re: [gentoo-dev] [PATCH 1/7] eclass/dotnet-pkg-base.eclass: quotes and style tweaks for edge cases

2024-02-07 Thread Sam James
Maciej Barć writes: > Signed-off-by: Maciej Barć > --- The series lgtm but please add some commit messages to them explaining the motivation / why we're doing it now if applicable. No need to re-send to ML once that's done. Thanks! > eclass/dotnet-pkg-base.eclass | 16 +++- >

Re: [gentoo-dev] [PATCH 1/7] eclass/dotnet-pkg-base.eclass: quotes and style tweaks for edge cases

2024-02-03 Thread Ulrich Mueller
> On Sat, 03 Feb 2024, Maciej Barć wrote: > -if [[ ${CATEGORY}/${PN} != dev-dotnet/dotnet-runtime-nugets ]] ; then > +if [[ "${CATEGORY}/${PN}" != dev-dotnet/dotnet-runtime-nugets ]] ; then These quotes are not necessary. > - if [[ ${CATEGORY}/${PN} != dev-dotnet/csharp-gentoodotnetinfo

[gentoo-dev] [PATCH 1/7] eclass/dotnet-pkg-base.eclass: quotes and style tweaks for edge cases

2024-02-03 Thread Maciej Barć
Signed-off-by: Maciej Barć --- eclass/dotnet-pkg-base.eclass | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/eclass/dotnet-pkg-base.eclass b/eclass/dotnet-pkg-base.eclass index 1a9d31120..e7484a6c5 100644 --- a/eclass/dotnet-pkg-base.eclass +++