Re: [gentoo-dev] [PATCH 2/3] verify-sig.eclass: Support `openssl dgst` format checksums

2023-09-08 Thread Ulrich Mueller
> On Fri, 08 Sep 2023, Michał Górny wrote: >> > + ! has "${filename}" "${files[@]}" && continue >> >> This might be clearer if it was written as: >> >> has "${filename}" "${files[@]}" || continue > Negative logic is never clearer. Exactly. That's why we generally do "command ||

Re: [gentoo-dev] [PATCH 2/3] verify-sig.eclass: Support `openssl dgst` format checksums

2023-09-08 Thread Michał Górny
On Fri, 2023-09-08 at 12:03 +0200, Michał Górny wrote: > On Mon, 2023-09-04 at 08:42 +0200, Ulrich Mueller wrote: > > > > > > > On Mon, 04 Sep 2023, Michał Górny wrote: > > > > > --- a/eclass/verify-sig.eclass > > > +++ b/eclass/verify-sig.eclass > > > @@ -214,12 +214,15 @@

Re: [gentoo-dev] [PATCH 2/3] verify-sig.eclass: Support `openssl dgst` format checksums

2023-09-08 Thread Michał Górny
On Mon, 2023-09-04 at 08:42 +0200, Ulrich Mueller wrote: > > > > > > On Mon, 04 Sep 2023, Michał Górny wrote: > > > --- a/eclass/verify-sig.eclass > > +++ b/eclass/verify-sig.eclass > > @@ -214,12 +214,15 @@ verify-sig_verify_message() { > >  } >   > > > > >  # @FUNCTION:

Re: [gentoo-dev] [PATCH 2/3] verify-sig.eclass: Support `openssl dgst` format checksums

2023-09-04 Thread Ulrich Mueller
> On Mon, 04 Sep 2023, Michał Górny wrote: > --- a/eclass/verify-sig.eclass > +++ b/eclass/verify-sig.eclass > @@ -214,12 +214,15 @@ verify-sig_verify_message() { > } > # @FUNCTION: verify-sig_verify_unsigned_checksums > -# @USAGE: > +# @USAGE: Below,

[gentoo-dev] [PATCH 2/3] verify-sig.eclass: Support `openssl dgst` format checksums

2023-09-03 Thread Michał Górny
Signed-off-by: Michał Górny --- eclass/tests/verify-sig.sh | 18 ++ eclass/verify-sig.eclass | 51 +- 2 files changed, 52 insertions(+), 17 deletions(-) diff --git a/eclass/tests/verify-sig.sh b/eclass/tests/verify-sig.sh index