Re: [gentoo-dev] [PATCH 4/4] distutils-r1.eclass: Disable LTO when using cargo.eclass

2023-07-12 Thread Michał Górny
On Wed, 2023-07-12 at 19:42 +0200, Ulrich Mueller wrote: > > > > > > On Wed, 12 Jul 2023, Michał Górny wrote: > > > + if [[ ${_CARGO_ECLASS} ]]; then > > + filter-lto > > + fi > > Testing for an internal variable of another eclass seems less than > ideal. How about "has cargo

Re: [gentoo-dev] [PATCH 4/4] distutils-r1.eclass: Disable LTO when using cargo.eclass

2023-07-12 Thread Ulrich Mueller
> On Wed, 12 Jul 2023, Michał Górny wrote: > + if [[ ${_CARGO_ECLASS} ]]; then > + filter-lto > + fi Testing for an internal variable of another eclass seems less than ideal. How about "has cargo ${INHERITED}" instead? Ulrich signature.asc Description: PGP signature

[gentoo-dev] [PATCH 4/4] distutils-r1.eclass: Disable LTO when using cargo.eclass

2023-07-12 Thread Michał Górny
Strip LTO flags when cargo.eclass is inherited. This means that Rust extensions are being built, and linking them with C/C++ style LTO results in broken shared libraries. Closes: https://bugs.gentoo.org/910220 Signed-off-by: Michał Górny --- eclass/distutils-r1.eclass | 7 +++ 1 file