Re: [gentoo-dev] [PATCH 8/8] virtualx.eclass: Simplify API into single virtx()

On Sat, Nov 28, 2015 at 4:50 PM, Justin Lecher (jlec) wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > On 28/11/15 16:28, Davide Pesavento wrote: >>> else - nonfatal ${VIRTUALX_COMMAND} "$@" + >>> nonfatal "$@" >> >> Please take the opportunity to

Re: [gentoo-dev] [PATCH 8/8] virtualx.eclass: Simplify API into single virtx()

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 30/11/15 18:40, Davide Pesavento wrote: > > The scenario of bug 517976 is different. I think a minimized test > case is the following (untested): > > foo() { die "meh" return 0 } > > src_test() { virtx foo } > This example will still break

[gentoo-dev] [PATCH 8/8] virtualx.eclass: Simplify API into single virtx()

The new API runs all specified arguments to virtx() inside an XFVB, instead of defining VIRTUALX_COMMAND and running that in virtualmake. Xemake and Xeconf should be replaced by "virtx emake" and "virtx econf". Signed-off-by: Justin Lecher --- eclass/virtualx.eclass | 42

Re: [gentoo-dev] [PATCH 8/8] virtualx.eclass: Simplify API into single virtx()

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 28/11/15 16:28, Davide Pesavento wrote: >> else - nonfatal ${VIRTUALX_COMMAND} "$@" + >> nonfatal "$@" > > Please take the opportunity to clean this up, possibly only in > EAPI=6 if you don't want to risk breaking existing ebuilds.

Re: [gentoo-dev] [PATCH 8/8] virtualx.eclass: Simplify API into single virtx()

On Sat, Nov 28, 2015 at 2:24 PM, Justin Lecher wrote: > The new API runs all specified arguments to virtx() inside an XFVB, > instead of defining VIRTUALX_COMMAND and running that in virtualmake. > > Xemake and Xeconf should be replaced by "virtx emake" and "virtx econf". > >