Re: [gentoo-dev] [PATCH v2 3/3] gnuconfig.eclass: use BDEPEND, BROOT where available (drop support for EAPI <4)

2021-04-09 Thread Alec Warner
On Fri, Apr 9, 2021 at 5:19 PM Sam James wrote: > > > > > On 10 Apr 2021, at 01:13, Michael Orlitzky wrote: > > > > On Sat, 2021-04-10 at 00:32 +0100, Sam James wrote: > >> > >> > >> Yes, this is the part I find difficult too. The important > >> distinction here was *bootstrapping* (which I

Re: [gentoo-dev] [PATCH v2 3/3] gnuconfig.eclass: use BDEPEND, BROOT where available (drop support for EAPI <4)

2021-04-09 Thread Sam James
> On 10 Apr 2021, at 01:13, Michael Orlitzky wrote: > > On Sat, 2021-04-10 at 00:32 +0100, Sam James wrote: >> >> >> Yes, this is the part I find difficult too. The important >> distinction here was *bootstrapping* (which I missed) >> but I think at least we should make a list of packages

Re: [gentoo-dev] [PATCH v2 3/3] gnuconfig.eclass: use BDEPEND, BROOT where available (drop support for EAPI <4)

2021-04-09 Thread Michael Orlitzky
On Sat, 2021-04-10 at 00:32 +0100, Sam James wrote: > > > Yes, this is the part I find difficult too. The important > distinction here was *bootstrapping* (which I missed) > but I think at least we should make a list of packages generally considered > critical for bootstrap. > What is a

Re: [gentoo-dev] [PATCH v2 3/3] gnuconfig.eclass: use BDEPEND, BROOT where available (drop support for EAPI <4)

2021-04-09 Thread Sam James
> On 7 Apr 2021, at 12:18, Michael Orlitzky wrote: > > On Tue, 2021-04-06 at 20:32 +0100, Sam James wrote: >> >>> >>> We usually don't add basic tools like grep to dependencies. >> >> Few points: >> >> ... > > 5) There are no clear rules about what @system packages can be left out > of

Re: [gentoo-dev] [PATCH v2 3/3] gnuconfig.eclass: use BDEPEND, BROOT where available (drop support for EAPI <4)

2021-04-09 Thread Sam James
> On 7 Apr 2021, at 12:06, Ulrich Mueller wrote: > >> On Tue, 06 Apr 2021, Sam James wrote: > >> 1) @system varies between profiles anyway which makes it hard to fully >> rely on; > > That's exactly the reason why you _don't_* add GNU grep as a dependency, > because e.g. on Prefix grep

Re: [gentoo-dev] [PATCH v2 3/3] gnuconfig.eclass: use BDEPEND, BROOT where available (drop support for EAPI <4)

2021-04-07 Thread Ulrich Mueller
> On Wed, 07 Apr 2021, Michael Orlitzky wrote: > 5) There are no clear rules about what @system packages can be left > out of *DEPEND and when, so their presence is wildly inconsistent. The rules are pretty clear for BDEPEND and bootstrap packages, which is what we're talking about here.

Re: [gentoo-dev] [PATCH v2 3/3] gnuconfig.eclass: use BDEPEND, BROOT where available (drop support for EAPI <4)

2021-04-07 Thread Michael Orlitzky
On Tue, 2021-04-06 at 20:32 +0100, Sam James wrote: > > > > > We usually don't add basic tools like grep to dependencies. > > Few points: > > ... 5) There are no clear rules about what @system packages can be left out of *DEPEND and when, so their presence is wildly inconsistent.

Re: [gentoo-dev] [PATCH v2 3/3] gnuconfig.eclass: use BDEPEND, BROOT where available (drop support for EAPI <4)

2021-04-07 Thread Ulrich Mueller
> On Tue, 06 Apr 2021, Sam James wrote: > 1) @system varies between profiles anyway which makes it hard to fully > rely on; That's exactly the reason why you _don't_* add GNU grep as a dependency, because e.g. on Prefix grep may be provided by another package. grep is a POSIX tool and a

Re: [gentoo-dev] [PATCH v2 3/3] gnuconfig.eclass: use BDEPEND, BROOT where available (drop support for EAPI <4)

2021-04-06 Thread Sam James
> On 5 Apr 2021, at 17:24, Ulrich Mueller wrote: > >> On Mon, 05 Apr 2021, Sam James wrote: > >> +4|5|6) >> +DEPEND=" >> +sys-apps/grep >> +sys-devel/gnuconfig >> +" >> +;; >> +7) >> +BDEPEND="

Re: [gentoo-dev] [PATCH v2 3/3] gnuconfig.eclass: use BDEPEND, BROOT where available (drop support for EAPI <4)

2021-04-05 Thread Ulrich Mueller
> On Mon, 05 Apr 2021, Sam James wrote: > + 4|5|6) > + DEPEND=" > + sys-apps/grep > + sys-devel/gnuconfig > + " > + ;; > + 7) > + BDEPEND=" > + sys-apps/grep We usually don't

[gentoo-dev] [PATCH v2 3/3] gnuconfig.eclass: use BDEPEND, BROOT where available (drop support for EAPI <4)

2021-04-05 Thread Sam James
EPREFIX is only available in > EAPI 2 but let's take the opportuinty to clean up in general. We don't want to keep worrying about *very* old EAPI cases, especially given other eclasses either barely - or don't - support it. Signed-off-by: Sam James --- eclass/gnuconfig.eclass | 41