Re: [gentoo-dev] Re: [PATCH 1/3] texlive-module.eclass: implicitly set TL_PV if not explicitly set

2024-02-29 Thread Michał Górny
On Thu, 2024-02-29 at 15:21 +0100, Florian Schmaus wrote: > On 29/02/2024 15.08, Michael Orlitzky wrote: > > On Thu, 2024-02-29 at 14:47 +0100, Florian Schmaus wrote: > > > > > > > > +if [[ -z ${TL_PV} ]] \ > > > > + && [[ ${EAPI} -ge 8 ]] \ > > > > > > I am skeptical of this

Re: [gentoo-dev] Re: [PATCH 1/3] texlive-module.eclass: implicitly set TL_PV if not explicitly set

2024-02-29 Thread Florian Schmaus
On 29/02/2024 15.34, Michael Orlitzky wrote: On Thu, 2024-02-29 at 15:21 +0100, Florian Schmaus wrote: The eclass only supports EAPIs {7,8,...} so it should suffice to blacklist EAPI=7. Fair point, but that would mean to remember to adjust this line once the eclass gets support for EAPI 9.

Re: [gentoo-dev] Re: [PATCH 1/3] texlive-module.eclass: implicitly set TL_PV if not explicitly set

2024-02-29 Thread Michael Orlitzky
On Thu, 2024-02-29 at 15:21 +0100, Florian Schmaus wrote: > > > > The eclass only supports EAPIs {7,8,...} so it should suffice to > > blacklist EAPI=7. > > Fair point, but that would mean to remember to adjust this line once the > eclass gets support for EAPI 9. > It should do the right

Re: [gentoo-dev] Re: [PATCH 1/3] texlive-module.eclass: implicitly set TL_PV if not explicitly set

2024-02-29 Thread Florian Schmaus
On 29/02/2024 15.08, Michael Orlitzky wrote: On Thu, 2024-02-29 at 14:47 +0100, Florian Schmaus wrote: +if [[ -z ${TL_PV} ]] \ + && [[ ${EAPI} -ge 8 ]] \ I am skeptical of this construct, as in the past we had non-numeric EAPIs. So I may have to go with EAPI == 8 for now. Input

Re: [gentoo-dev] Re: [PATCH 1/3] texlive-module.eclass: implicitly set TL_PV if not explicitly set

2024-02-29 Thread Michael Orlitzky
On Thu, 2024-02-29 at 14:47 +0100, Florian Schmaus wrote: > > > > +if [[ -z ${TL_PV} ]] \ > > + && [[ ${EAPI} -ge 8 ]] \ > > I am skeptical of this construct, as in the past we had non-numeric > EAPIs. So I may have to go with EAPI == 8 for now. Input appreciated. > The eclass only

[gentoo-dev] Re: [PATCH 1/3] texlive-module.eclass: implicitly set TL_PV if not explicitly set

2024-02-29 Thread Florian Schmaus
On 29/02/2024 14.38, Florian Schmaus wrote: Signed-off-by: Florian Schmaus --- eclass/texlive-module.eclass | 6 ++ 1 file changed, 6 insertions(+) diff --git a/eclass/texlive-module.eclass b/eclass/texlive-module.eclass index afcd4532975a..d1bf0f86185b 100644 ---