Re: [gentoo-portage-dev] Re: equery refactorization

2008-12-06 Thread Michael A. Smith
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 If we go there, we will need to transition equery from where it is to the new stable interface through a path of functional deprecation notices. We should have a plan. I also think before any collaborative refactoring gets underway we need more conse

Re: [gentoo-portage-dev] Re: equery refactorization

2008-12-06 Thread Douglas Anderson
On Sun, Dec 7, 2008 at 1:26 PM, Marius Mauch <[EMAIL PROTECTED]> wrote: > On Sun, 7 Dec 2008 12:44:25 +0900 > "Douglas Anderson" <[EMAIL PROTECTED]> wrote: > >> I also thought about renaming the "list(l)" option as "search", >> because if you look at the help output, almost every module "lists" >>

Re: [gentoo-portage-dev] Re: equery refactorization

2008-12-06 Thread Marius Mauch
On Sun, 7 Dec 2008 12:44:25 +0900 "Douglas Anderson" <[EMAIL PROTECTED]> wrote: > I also thought about renaming the "list(l)" option as "search", > because if you look at the help output, almost every module "lists" > something. equery's "list" is actually a search, I don't see why we > shouldn't

Re: [gentoo-portage-dev] Python style (Was: equery refactorization)

2008-12-06 Thread Douglas Anderson
On Sun, Dec 7, 2008 at 9:50 AM, Zac Medico <[EMAIL PROTECTED]> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Michael A. Smith wrote: >> Actually I don't like spaces for indentation at all. A tab character and a >> space character take the same number of bytes, so it takes two-to-eigh

Re: [gentoo-portage-dev] Re: equery refactorization

2008-12-06 Thread Douglas Anderson
On Sun, Dec 7, 2008 at 12:34 PM, Michael A. Smith <[EMAIL PROTECTED]> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Let me rephrase: > > The tests as they are written are not all that helpful or functional. > Therefore > I'm refactoring them so that they are. If I don't, they won't b

Re: [gentoo-portage-dev] Re: equery refactorization

2008-12-06 Thread Michael A. Smith
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Let me rephrase: The tests as they are written are not all that helpful or functional. Therefore I'm refactoring them so that they are. If I don't, they won't be any good at all. These are not sophisticated tests that comprehensively review your co

Re: [gentoo-portage-dev] Re: equery refactorization

2008-12-06 Thread Douglas Anderson
On Sun, Dec 7, 2008 at 12:02 PM, Michael A. Smith <[EMAIL PROTECTED]> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Regarding gentoolkit/trunk/src/equery/tests > > I discovered all the test kit that's in equery, and have been refactoring > 'em. > They're written in bash, not python,

[gentoo-portage-dev] Re: equery refactorization

2008-12-06 Thread Michael A. Smith
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Regarding gentoolkit/trunk/src/equery/tests I discovered all the test kit that's in equery, and have been refactoring 'em. They're written in bash, not python, so they're a candidate for some kind of python unit testing. Right now, however, that's no

Re: [gentoo-portage-dev] Python style (Was: equery refactorization)

2008-12-06 Thread Zac Medico
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Michael A. Smith wrote: > Actually I don't like spaces for indentation at all. A tab character and a > space character take the same number of bytes, so it takes two-to-eight > times > as much space per indentation to store the same indentation as a si

[gentoo-portage-dev] [Fwd: Re: equery refactorization]

2008-12-06 Thread Michael A. Smith
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I sent this to Douglas, but not to the list. Re-sending. - Original Message From: Michael Smith <[EMAIL PROTECTED]> To: [EMAIL PROTECTED], Douglas Anderson <[EMAIL PROTECTED]> Subject: Re: equery refactorization Date: Tue, 2 Dec 20

Re: [gentoo-portage-dev] Re: equery refactorization

2008-12-06 Thread Michael A. Smith
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Douglas Anderson wrote: | On Thu, Dec 4, 2008 at 2:43 PM, Alec Warner <[EMAIL PROTECTED]> wrote: |> |> Don't put stuff in __init__.py. |> |> Make a file called equery (no .py) and do all the work in the modules |> you import; eg. |> |> from equery im

[gentoo-portage-dev] Python style (Was: equery refactorization)

2008-12-06 Thread Michael A. Smith
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Actually I don't like spaces for indentation at all. A tab character and a space character take the same number of bytes, so it takes two-to-eight times as much space per indentation to store the same indentation as a single tab character. On the aver