[gentoo-portage-dev] [PATCH] eapply_user: Make idempotent per changes to EAPI 6

2015-11-11 Thread Michał Górny
--- bin/phase-helpers.sh | 4 1 file changed, 4 insertions(+) diff --git a/bin/phase-helpers.sh b/bin/phase-helpers.sh index 2fea0b2..511a41a 100644 --- a/bin/phase-helpers.sh +++ b/bin/phase-helpers.sh @@ -1070,6 +1070,10 @@ fi if ___eapi_has_eapply_user; then eapply_user() { +

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-11 Thread Mike Frysinger
On 11 Nov 2015 10:32, Michał Górny wrote: > I'm not convinced we ought to do this for EAPI < 6. It is a breaking > change after all, and as such changes the behavior of EAPI < 6 ebuilds. that is a false statement. anything not working with bash-3.2 is already broken according to the PMS. >

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-11 Thread Mike Frysinger
On 11 Nov 2015 07:33, Ulrich Mueller wrote: > > On Tue, 10 Nov 2015, Mike Frysinger wrote: > > + # Set the compat level in case things change with newer ones. We must > > not > > + # export this into the env otherwise we might break other shell > > scripts we > > + # execute (e.g.

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-11 Thread Michał Górny
On Tue, 10 Nov 2015 23:39:29 -0500 Mike Frysinger wrote: > To try and provide better stability across bash versions, > set the language compat level based on the current EAPI. > --- > bin/eapi.sh | 8 > bin/ebuild.sh | 39 +++ >

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-11 Thread Ulrich Mueller
> On Wed, 11 Nov 2015, Michał Górny wrote: > I'm not convinced we ought to do this for EAPI < 6. It is a breaking > change after all, and as such changes the behavior of EAPI < 6 > ebuilds. Which according to PMS should assume bash version 3.2. Also, AFAICS the only feature where the compat

Re: [gentoo-portage-dev] [PATCH] egencache: parallelize --update-changelogs (bug 565540)

2015-11-11 Thread Robin H. Johnson
Confirmed to work; please merge (also my prior patch that fixes relative GIT_DIR implications, or ACK and I will merge it myself). Speedup is less than expected however. Running with: --jobs 10 --load-average 6 yields a ~3.3x speedup on the previous non-parallel version. With the system load

Re: [gentoo-portage-dev] [PATCH] egencache: fix results when GIT_DIR is used in the environment.

2015-11-11 Thread Zac Medico
On 11/11/2015 02:30 PM, robb...@gentoo.org wrote: > From: "Robin H. Johnson" > > If GIT_DIR is used, and .git is outside the root of the checkout, then > --work-tree=... needs to be specified, otherwise any Git command that > relies on relative directories to the root will be

Re: [gentoo-portage-dev] [PATCH v2] ebuild: set up bash compat levels

2015-11-11 Thread Zac Medico
On 11/11/2015 01:00 PM, Mike Frysinger wrote: > To try and provide better stability across bash versions, > set the language compat level based on the current EAPI. > This does not ban newer features, it tells bash to use > the older bash behavior when the behavior changes across > versions. > ---

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-11 Thread Zac Medico
On 11/11/2015 01:11 PM, Mike Frysinger wrote: > On 11 Nov 2015 13:04, Zac Medico wrote: >> On 11/11/2015 12:55 PM, Mike Frysinger wrote: >>> On 11 Nov 2015 11:42, Zac Medico wrote: On 11/10/2015 08:39 PM, Mike Frysinger wrote: > +# Set up the bash version compatibility level. >

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-11 Thread Zac Medico
On 11/11/2015 10:33 PM, Zac Medico wrote: > On 11/11/2015 01:11 PM, Mike Frysinger wrote: >> On 11 Nov 2015 13:04, Zac Medico wrote: >>> On 11/11/2015 12:55 PM, Mike Frysinger wrote: On 11 Nov 2015 11:42, Zac Medico wrote: > On 11/10/2015 08:39 PM, Mike Frysinger wrote: >> +# Set up

[gentoo-portage-dev] [PATCH] egencache: parallelize --update-changelogs (bug 565540)

2015-11-11 Thread Zac Medico
Use the TaskScheduler class to parallelize GenChangeLogs. Fix AsyncFunction so it does not re-define 'args' in __slots__. X-Gentoo-Bug: 565540 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=565540 --- bin/egencache| 24 +++-

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-11 Thread Zac Medico
On 11/10/2015 08:39 PM, Mike Frysinger wrote: > To try and provide better stability across bash versions, > set the language compat level based on the current EAPI. > --- > bin/eapi.sh | 8 > bin/ebuild.sh | 39 +++ > 2 files changed, 47

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-11 Thread Mike Frysinger
On 11 Nov 2015 13:04, Zac Medico wrote: > On 11/11/2015 12:55 PM, Mike Frysinger wrote: > > On 11 Nov 2015 11:42, Zac Medico wrote: > >> On 11/10/2015 08:39 PM, Mike Frysinger wrote: > >>> +# Set up the bash version compatibility level. > >>> +__check_bash_version() { > >> > >> Please unset all

[gentoo-portage-dev] [PATCH] Warn if LC_CTYPE does not toupper()/tolower() ASCII chars correctly

2015-11-11 Thread Michał Górny
Output a warning if LC_CTYPE is set to a value that causes libc toupper() and/or tolower() conversions not apply correctly to printable ASCII characters. --- pym/_emerge/actions.py | 40 1 file changed, 40 insertions(+) diff --git a/pym/_emerge/actions.py

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-11 Thread Mike Frysinger
On 11 Nov 2015 11:42, Zac Medico wrote: > On 11/10/2015 08:39 PM, Mike Frysinger wrote: > > +# Set up the bash version compatibility level. > > +__check_bash_version() { > > Please unset all new internal function inside bin/save-ebuild-env.sh. > Note that it already uses this line to unset

[gentoo-portage-dev] [PATCH v2] ebuild: set up bash compat levels

2015-11-11 Thread Mike Frysinger
To try and provide better stability across bash versions, set the language compat level based on the current EAPI. This does not ban newer features, it tells bash to use the older bash behavior when the behavior changes across versions. --- bin/eapi.sh| 8 bin/ebuild.sh

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-11 Thread Zac Medico
On 11/11/2015 12:55 PM, Mike Frysinger wrote: > On 11 Nov 2015 11:42, Zac Medico wrote: >> On 11/10/2015 08:39 PM, Mike Frysinger wrote: >>> +# Set up the bash version compatibility level. >>> +__check_bash_version() { >> >> Please unset all new internal function inside bin/save-ebuild-env.sh. >>

[gentoo-portage-dev] [PATCH] egencache: fix results when GIT_DIR is used in the environment.

2015-11-11 Thread robbat2
From: "Robin H. Johnson" If GIT_DIR is used, and .git is outside the root of the checkout, then --work-tree=... needs to be specified, otherwise any Git command that relies on relative directories to the root will be wrong. Signed-off-by: Robin H. Johnson